Repository navigation
Handle all shells’ de/activation - #137
Merged
Karthik Nadig (karthiknadig) merged 4 commits intoJan 27, 2025
Merged
Conversation
Member
|
Thanks for the PR! Love the new shell command handling. |
Karthik Nadig (karthiknadig)
enabled auto-merge (squash)
January 25, 2025 18:52
Karthik Nadig (karthiknadig)
requested review from
Anthony Kim (anthonykim1) and
Eleanor Boyd (eleanorjboyd)
January 25, 2025 22:28
Contributor
|
Thanks for doing this Philipp A. (@flying-sheep) The list on https://github.com/microsoft/vscode/blob/e8346324cfb8b5d680ad657bb67153eb838aebc5/src/vscode-dts/vscode.proposed.terminalShellType.d.ts are subject to change, so feel free to let me know if anyone thinks more shell types could be added to make the workload easier on the extension side. As we want to make sure to cover extensive list of shell types for their specific activation. |
Anthony Kim (anthonykim1)
approved these changes
Jan 27, 2025
Karthik Nadig (karthiknadig)
approved these changes
Jan 27, 2025
NgCuong (NguyenCuong1989)
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
Fixes #138 This adds shell activation for - gitbash - wsl - ksh - tcshell - xonsh - nushell and fixes shell activation for C shell. it also makes sure that it’s impossible to add a terminal to the enum without also adding shell activation/deactivation commands by using a `Record` type that needs to be exhaustive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
This adds shell activation for
and fixes shell activation for C shell.
it also makes sure that it’s impossible to add a terminal to the enum without also adding shell activation/deactivation commands by using a
Recordtype that needs to be exhaustive.