Skip to content

Remove quickPickSeparators API proposal from package.json #18363

Closed
#18384
Closed
Remove quickPickSeparators API proposal from package.json#18363
#18384
Assignees
karrtikr
Labels
area-editor-*User-facing catch-alldebtCode quality issuesverifiedVerification succeeded
Milestone
January 2022

Description

@joyceerhl
Joyce Er (joyceerhl)
opened on Jan 25, 2022

The Python extension's daily builds still declare the following API proposal, which TylerLeonhardt has finalized in Insiders and which ship in the next stable release:

vscode-python/package.json

Line 24 in f660cb6

"quickPickSeparators",

This causes a warning in dev tools (cc Johannes Rieken (@jrieken)):

image

Activity

  1. Imagegithub-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Jan 25, 2022

  2. jrieken commented on Jan 26, 2022

    @jrieken
    Johannes Rieken (jrieken)
    on Jan 26, 2022

    We can make this less dramatic - we have logic to detect a diff between enabled and wanted API proposals but in this case it's about an extension wanting a proposed that doesn't exist anymore. So that specific case could be handled with a more specialized message

  3. ImageJohannes Rieken (jrieken)
    added a commit that references this issue on Jan 26, 2022

    better warning when an extension depends on an API proposal that does…

    4a0927c

  4. jrieken commented on Jan 26, 2022

    @jrieken
    Johannes Rieken (jrieken)
    on Jan 26, 2022

    I have pushed a change that improves the warning on our end, tho a warning is the best we can do

  5. Imagesourcegraph-bot
    added a commit that references this issue on Jan 26, 2022

    vscode: better warning when an extension depends on an API proposal t…

    3c53507
  6. ImageKarthik Nadig (karthiknadig)
    assigned
    Kartik Raj (karrtikr)
    on Jan 26, 2022
  7. ImageKarthik Nadig (karthiknadig)
    added
    area-editor-*User-facing catch-all
    triage
    debtCode quality issues
    and removed
    triage-neededNeeds assignment to the proper sub-team
    on Jan 26, 2022
  8. ImageKartik Raj (karrtikr)
    added
    needs PR
    and removed
    triage
    on Jan 26, 2022
  9. ImageKartik Raj (karrtikr)
    closed this as completedin #18384on Jan 27, 2022
  10. ImageKartik Raj (karrtikr)
    added this to the January 2022 milestone on Jan 27, 2022
  11. ImageKartik Raj (karrtikr)
    added
    verifiedVerification succeeded
    on Jan 27, 2022
  12. Imagegithub-actions
    locked as resolved and limited conversation to collaborators on Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-editor-*User-facing catch-alldebtCode quality issuesverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions