Repository navigation
Use npm package diff to parse diff patches #1950
Description
Refactor diff patch parsing to use an npm package.
Currently most of this is done by hand with a use of an npm package diff-match-patch. In the past 5 years there have been just two versions of this npm package.
Suggest we to move over to diff.
Significantly more popular (4million downloads vs 105k a month, compare diff-match-patch)
Affected areas:
- Formatting
- Refactoring
- Sorting Imports
Activity
DonJayamanne commentedon Oct 2, 2018
All 3 parts (formatting and refactoring) will be moved into the language server.
Brett Cannon (@brettcannon) does this mean we can close this issue?
If not, then we'll need to remove
P1as support for Non-LS is lower.brettcannon commentedon Oct 2, 2018
It's a question for Dan Taylor (@qubitron) on how far we want to take the non-LS support.
qubitron commentedon Oct 2, 2018
Not very far, sounds like this is refactoring? I think that should be all handled inside of the language server.
DonJayamanne commentedon Oct 3, 2018
I think we can close this issue now