Repository navigation
Fix colon-triggered block formatting - #2724
Merged
Don Jayamanne (DonJayamanne) merged 3 commits intoSep 29, 2018
Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
Don Jayamanne (DonJayamanne) merged 3 commits into
Conversation
Jake Bailey (jakebailey)
requested a review
from Don Jayamanne (DonJayamanne)
September 28, 2018 20:47
Don Jayamanne (DonJayamanne)
approved these changes
Sep 29, 2018
|
Dispatcher is perfect. Though I wouldn't have added the dispatchers via the ctor, would have preferred an add method. |
6 tasks done
Don Jayamanne (DonJayamanne)
pushed a commit
that referenced
this pull request
Oct 9, 2018
For #2690. Similar to #2612. Note that `:`-based formatting isn't implemented in language server yet (microsoft/python-language-server#165), but it hasn't been enabled in the extension for anyone for a while now either (fixed in #2714/#2724). Since line formatting is relatively new in language server, this likely shouldn't make it out into a release until the language server downloaded by default is new enough to include that functionality. I haven't been monitoring that side of things, so feel free to hold off on merging this until the right time.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2714.
Open to suggestions for naming the added class (if "dispatcher" isn't a good choice). As mentioned in #2714, this doesn't contain tests for things outside of the specific added class (i.e. integration). I haven't written anything in TypeScript before, so let me know if something here is unidiomatic or wrong.
Any new/changed dependencies inpackage.jsonare pinned (e.g."1.2.3", not"^1.2.3"for the specified version)package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)