Skip to content

Test: terminal find / display all matches #145629

Closed

Description

Refs: #134790

Complexity: 3

Authors: Megan Rogge (@meganrogge)

Create Issue


We want to align the terminal find experience with that of the editor, so this iteration, made use of the new Xterm registerDecoration API to do so.

Verify that the find experience in the terminal:

  • feels nice
  • looks good
  • behaves similarly to the editor
  • shows scrollbar annotations in the right places and an indicator for the currently selected term that updates with findNext and findPrevious
  • try setting workbench.colorCustomizations.editor.findMatchBackground and workbench.colorCustomizations.editor.findMatchHighlightBackground to custom colors. These should work on the next search
  • try searching for something then adding lines to the buffer - the search results should be updated
  • scrolling shouldn't impact anything
  • closing the find widget (that still has input) should remove the decorations
  • clearing the find widget should delete the decorations

Known issues:

Activity

  1. Tyriar commented on Mar 22, 2022

    @Tyriar
    Contributor

    Added myself as a tester despite doing a bit of the end work on it as I want to test it thoroughly anyway.

  2. removed their assignment
    on Mar 23, 2022
  3. locked and limited conversation to collaborators on May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions