Skip to content

Enhancement: Minimap position highlight  #21404

Closed
microsoft/azuredatastudio
#7206

Description

  • VSCode Version: 1.10.0-insiders (2017-02-24)
  • OS Version: Windows 10

I have some enhancement requests for the current minimap implementation which are already available in Atom as separate plugins.

  1. 1. Enable the minimap in latest insider build and position your cursor in the editor. The minimap does not highlight (ligh grey background) your current position unless you hover over the minimap. I would like this highlight to be enabled at all time.
  2. 2. Add CSS color display in the minimap, this is available in Atom as a separate plugin minimap-pigments which I find very convenient.
  3. 3. Highlight the text in the editor would also highlight the text in the minimap. This is only available in Sublime Text and has a white background (instead of grey)... see print screen.

atom_minimap

Activity

  1. mika76 commented on Feb 25, 2017

    @mika76

    I think 3 is the one I mostly use - so easy to find or find and replace when you can see the highlights in the minimap - as long as they are very visible (strong contrast) - in atom and sublime the highlights are not nearly as visible as they should be, it's too easy to miss them in the syntax colors...

  2. sillero commented on Mar 1, 2017

    @sillero

    if minimap is enabled AND with the behavior fixed as Ghislain B. (@ghiscoding) suggested, we don't need that slim default bar, minimap replaces it

  3. rmunn commented on Mar 9, 2017

    @rmunn
    Contributor

    Request 1 (always show the viewport on the minimap) is now being tracked at #21784. Request 3 seems to be a partial duplicate of #20934 ("editor selection" is one of the things asked for in that issue). Request 2 does not have any duplicates that I could find.

  4. jens1o commented on Mar 14, 2017

    @jens1o
    Contributor

    I would like it when the current line is also highlighted in the minimap.

  5. globaltommy commented on Mar 28, 2017

    @globaltommy

    I'm very surprised there is no highlight on minimap - guess will STILL stick with atom.io for now.

  6. abhijitvalluri commented on Apr 3, 2017

    @abhijitvalluri

    Request 3 is a feature that exists in Atom, at least via third-party packages. In my opinion, that is very much needed and without that the utility of the minimap is questionable at best. Hopefully they will implement this feature soon.

    In the meantime, I'll still be sticking with VScode instead of atom as I totally love the git integration in VScode, including the diff feature and due to the search feature being in the sidebar rather than editor window.

  7. abhijitvalluri commented on Apr 15, 2017

    @abhijitvalluri

    I quickly hacked together a rudimentary implementation of Request 1 and 3 at abhijitvalluri@a1f2d2f

    For request 3, I couldn't yet figure out how to highlight just the precise token corresponding to the word that is highlighted. So, instead I decided to highlight the entire line. In my opinion, this is probably a bit better as it is easier to see the whole line light up instead of just the word, which will be much smaller and harder to spot.

    Example screenshot:
    vscode_enhanced

    You could take that code, modify it and make your own custom version of vscode. And if you can make it nicer still go ahead and send in a PR!

  8. abhijitvalluri commented on Apr 17, 2017

    @abhijitvalluri

    Made some improvements to the minimap highlight implementation: https://github.com/abhijitvalluri/vscode/commits/minimap_enhancements

    Right now, all the implementation details are hardcoded, including it being set up for a dark theme. Also, there is a bug wherein if the file is too large, so that the minimap scrolls and does not fit entirely in one view, then only highlights for the portion of the file that is visible in the minimap works. Once you scroll, there are no highlights for the invisible part of the file in the minimap.
    minimap_highlight

    UPDATE:
    I have made the necessary changes to fix the issues I mentioned above: highlights work correctly even for very long files, scrolling does not remove highlights etc. in abhijitvalluri@46c6691

    If you don't mind this hardcoded feature, and are fine with the dark theme, then you can make a packaged version of this by running:

    gulp vscode-[platform]-min
    

    And then you will have your very own vscode with highlighting in the minimap. This is good enough for me, for now! So I am using this as my default version of vscode! 🤓

  9. ghiscoding commented on Apr 17, 2017

    @ghiscoding
    Author

    alexandrudima do you think it would be possible to use/merge the code provided by Abhijit Kiran Valluri (@abhijitvalluri) for the number 3. that I have in the list

    1. Highlight the text in the editor would also highlight the text in the minimap. This is only available in Sublime Text and has a white background (instead of grey).
  10. abhijitvalluri commented on Apr 17, 2017

    @abhijitvalluri

    My code may not be in a good shape for merging. So, I can clean it up if needed so that these changes can be made use of in vscode! Do let me know.

  11. ghiscoding commented on Jun 8, 2017

    @ghiscoding
    Author

    The number (1) from the list has now been implemented Minimap: add a alwaysShowViewport setting - 21784. A new setting will available in the June version. "editor.minimap.showSlider": "always"

  12. 37 remaining items

  13. dcastil commented on Jun 11, 2019

    @dcastil

    I'd like to see the minimap have all the highlighting features of the scrollbar to replace the scrollbar completely. It feels strange and unnecessary to have two scrollbars for the same window.

  14. ghiscoding commented on Jun 11, 2019

    @ghiscoding
    Author

    I've added a comment in next June 2019 Iteration Plan, you guys can up vote there as well if you wish.

  15. MatrosSkin commented on Jun 11, 2019

    @MatrosSkin

    Here is a link to comment to vote: #75103 (comment)

  16. mirineumark commented on Jul 5, 2019

    @mirineumark

    So....The new version came out. It....sort of has this feature we have been waiting for for 2.5 years. A couple problems:

    1. It only highlights in the minimap if you search the page. Double-clicking on things that highlights other instances of it on the page does not do anything in the minimap.

    2. The highlight is so tiny and subtle it might as well not have been added. Its supposed to highlight in a way that is clear and obvious and instead its so hard to see that in the documentation they had to add a circle around the part of the minimap so people would be able to tell it was there at all.

    Any chance these can be fixed in less time than 2.5 years? These seem like pretty simple changes to make.

  17. ghiscoding commented on Jul 9, 2019

    @ghiscoding
    Author

    Our wishes might have been heard...

    🔴 Support multi-line decorations in the minimap Rachel Macfarlane (@RMacfarlane)
    🔴 Explore improving presentation of search results in minimap (size, theme color) Rachel Macfarlane (@RMacfarlane)

    that was pulled from July Iteration Plan (2019), it does sound like this ticket 🤞

    EDIT

    Unfortunately, they are actually different issues with similar subject title. I'm afraid that our issue will not be addressed at this time. Sad to see that it takes years to look into this 😿

  18. stiegi commented on Aug 12, 2019

    @stiegi

    With the release of 1.37.0 we kind of have that feature now. The only downside is that it doesn't work on simple selections, but on searches only. That means you need to doubleclick first, and press CTRL+F afterwards... We are almost there. Is there a way to automate searching for the selection?

  19. PierreMarchand20 commented on Aug 12, 2019

    @PierreMarchand20

    I tried to talk about it in #78807 along another issue which is assigned to the person who implemented the feature for the search selection. Wait and see

  20. RMacfarlane commented on Aug 12, 2019

    @RMacfarlane

    Hey all! I did the work on search results in the minimap, which was the first step of enabling decorations in the minimap. This was meant to be the foundation for further decoration improvements to the minimap. I'm not working on this in the current iteration, but this issue is on my radar!

  21. ghiscoding commented on Aug 12, 2019

    @ghiscoding
    Author

    Rachel Macfarlane (@RMacfarlane)
    This is great news, thanks for the info. We waited 2.5 years, so I'm sure we could wait for another iteration before seeing it implemented. We just hope it will be this year lol

  22. RMacfarlane commented on Sep 11, 2019

    @RMacfarlane

    I've just checked in the change for showing selection decorations in the minimap, it will be available in tomorrow's VSCode Insiders if you want to try it out early, otherwise in our next stable release in October.

  23. ghiscoding commented on Sep 11, 2019

    @ghiscoding
    Author

    Rachel Macfarlane (@RMacfarlane)
    Thanks for the change, this is very welcome change on the productivity side.

    Note that I proposed 3 enhancements and now 2/3 are done, we are still missing the "Show Color in Minimap" but it was not as high interested as the other 2 were. You close the issue but I wonder if that would be doable in the future? Should that be a separate issue?

  24. RMacfarlane commented on Sep 11, 2019

    @RMacfarlane

    Ghislain B. (@ghiscoding) Can you open a separate issue to track that?

  25. locked and limited conversation to collaborators on Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions