Skip to content

Contribution point for timeline provider #94151

Closed
#148052
Closed
Contribution point for timeline provider#94151
#148052
Assignees
lramos15JacksonKearl
Labels
feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsiderstimelineTimeline view issuesverification-neededVerification of issue is requestedverifiedVerification succeeded
Milestone
May 2022

Description

@sandy081
Sandeep Somavarapu (sandy081)
opened on Apr 1, 2020

Testing #93820

Why is not there a package.json contribution point for timeline provider? Following are the advantages

  • I am not sure how I have to activate my extension if I only contribute timeline provider. Having a timeline contribution point can allow me to activate my extension when user starts using the timeline my extension contributes

  • Also helps in displaying the feature contributions in extension editor view

Activity

  1. ImageSandeep Somavarapu (sandy081)
    assigned
    Eric Amodio (eamodio)
    on Apr 1, 2020
  2. ImageEric Amodio (eamodio)
    added
    feature-requestRequest for new features or functionality
    timelineTimeline view issues
    on Apr 7, 2020
  3. ImageEric Amodio (eamodio)
    added this to the Backlog milestone on Apr 7, 2020

  4. eamodio commented on Apr 7, 2020

    @eamodio
    Eric Amodio (eamodio)
    on Apr 7, 2020
    Contributor

    Sandeep Somavarapu (@sandy081): Johannes Rieken (@jrieken) and I talked about supporting this originally but felt that it was something that could be added later.

  5. jrieken commented on Apr 7, 2020

    @jrieken
    Johannes Rieken (jrieken)
    on Apr 7, 2020
    Contributor

    Hm, not sure... Somehow timeline feels like master-detail, e.g you open an editor and the timeline shows its contents. With that usage-pattern it feels wrong to have an activation event. Then there is the 'Open timeline' command which is different... You could that command as activation event and all is good

  6. sandy081 commented on Apr 7, 2020

    @sandy081
    Sandeep Somavarapu (sandy081)
    on Apr 7, 2020
    MemberAuthor

    On what event shall an extension contributing a timeline should be activated?

  7. jrieken commented on Apr 7, 2020

    @jrieken
    Johannes Rieken (jrieken)
    on Apr 7, 2020
    Contributor

    For instance these onCommand:openTimeline and onFilesystem:foo

  8. eamodio commented on Oct 7, 2020

    @eamodio
    Eric Amodio (eamodio)
    on Oct 7, 2020
    Contributor

    Johannes Rieken (@jrieken) should we support an onView:timeline activation? Rather than a really specific point just for the timeline?

  9. jrieken commented on Oct 8, 2020

    @jrieken
    Johannes Rieken (jrieken)
    on Oct 8, 2020
    Contributor

    Yeah, that would make sense

  10. ImageLogan Ramos (lramos15)
    assigned
    Jackson Kearl (JacksonKearl)
    and unassigned
    Eric Amodio (eamodio)
    on Oct 8, 2021
  11. ImageJackson Kearl (JacksonKearl)
    modified the milestones: Backlog, On Deck on Oct 8, 2021
  12. ImageJackson Kearl (JacksonKearl)
    assigned
    Logan Ramos (lramos15)
    on Apr 7, 2022
  13. ImageJackson Kearl (JacksonKearl)
    modified the milestones: On Deck, April 2022 on Apr 8, 2022
  14. ImageLogan Ramos (lramos15)
    added a commit that references this issue on Apr 25, 2022

    Fix #94151

    9816a53
  15. ImageLogan Ramos (lramos15)
    modified the milestones: April 2022, May 2022 on Apr 26, 2022
  16. ImageLogan Ramos (lramos15)
    closed this as completedin #148052on May 6, 2022
  17. ImageLogan Ramos (lramos15)
    added a commit that references this issue on May 6, 2022

    Fix #94151 (#148052)

    df5abb3
  18. ImageVS Code Issue Triage Bot (vscode-triage-bot)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on May 6, 2022
  19. ImageLogan Ramos (lramos15)
    added
    verification-neededVerification of issue is requested
    on May 27, 2022

  20. lramos15 commented on May 27, 2022

    @lramos15
    Logan Ramos (lramos15)
    on May 27, 2022
    Member

    To verify ensure that your extension that contributes a timeline can activate properly when the timeline is revealed via the onView:timeline activation

  21. ImageSandeep Somavarapu (sandy081)
    added
    verifiedVerification succeeded
    on Jun 1, 2022
  22. Imagegithub-actions
    locked and limited conversation to collaborators on Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code InsiderstimelineTimeline view issuesverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions