Add terminal colors to Monokai Dimmed theme #98322

Activity

1. VS Code Issue Triage Bot (vscode-triage-bot)

   assigned

   Daniel Imms (Tyriar)

   on May 21, 2020
2. VS Code Issue Triage Bot (vscode-triage-bot)

   added

   terminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label

   on May 21, 2020
3. Daniel Imms (Tyriar)

   removed

   terminalGeneral terminal issues that don't fall under another labelGeneral terminal issues that don't fall under another label

   on May 26, 2020
4. Daniel Imms (Tyriar)

   assigned

   Miguel Solorio (miguelsolorio)

   and unassigned

   Daniel Imms (Tyriar)

   on May 26, 2020
5. Miguel Solorio (miguelsolorio)

   closed this as completedin #98323on May 26, 2020
6. miguelsolorio commented on May 26, 2020

   

   Miguel Solorio (miguelsolorio)

   on May 26, 2020

   Contributor

   More actions

   👍 This looks much better, thanks for the PR!

   Before

   

   After

   
7. Miguel Solorio (miguelsolorio)

   added this to the May 2020 milestone on May 26, 2020
8. Miguel Solorio (miguelsolorio)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   themesColor theme issuesColor theme issues

   verification-neededVerification of issue is requestedVerification of issue is requested

   on May 26, 2020
9. JanisGailis commented on May 27, 2020

   

   Jānis Gailis (JanisGailis)

   on May 27, 2020

   Author

   More actions

   @misolori Thanks for accepting the PR!

   As a side note, I quickly looked at the other themes, and many of them haven't set any terminal colors, and even the ones that have them set usually haven't aligned ANSI black with the background, leading to weird-looking 'fancy shell features':

   

   

   Then again, there are documented ways how to adjust the color palettes for a particular VSCode installation or workspace, and this is quite likely a bit of an edge case anyway.

   Thanks for all the good work you guys have been doing!
10. Martin Aeschlimann (aeschli)

    added

    verifiedVerification succeededVerification succeeded

    on Jun 3, 2020
11. ejose19 commented on Jun 20, 2020

    

    ejose19

    on Jun 20, 2020

    Last edited by ejose19

    More actions

    Is there an option to disable this? or if there's not what would be the values one would need to set on terminal.X to revert what the commit changed? I prefer the non washed terminal and noticed this changed on last update.

    Edit: For anyone looking to use default terminal colors, add this to settings.json

    "workbench.colorCustomizations": {
      "terminal.ansiBlack": "#000000",
      "terminal.ansiBlue": "#2472c8",
      "terminal.ansiBrightBlack": "#666666",
      "terminal.ansiBrightBlue": "#3b8eea",
      "terminal.ansiBrightCyan": "#29b8db",
      "terminal.ansiBrightGreen": "#23d18b",
      "terminal.ansiBrightMagenta": "#d670d6",
      "terminal.ansiBrightRed": "#f14c4c",
      "terminal.ansiBrightWhite": "#e5e5e5",
      "terminal.ansiBrightYellow": "#f5f543",
      "terminal.ansiCyan": "#11a8cd",
      "terminal.ansiGreen": "#0dbc79",
      "terminal.ansiMagenta": "#bc3fbc",
      "terminal.ansiRed": "#cd3131",
      "terminal.ansiWhite": "#e5e5e5",
      "terminal.ansiYellow": "#e5e510",
      "terminal.border": "#80808059",
      "terminal.foreground": "#cccccc",
      "terminal.selectionBackground": "#ffffff40"
    }
    

    👍React with 👍1Reacted by Jānis Gailis
12. github-actions

    locked and limited conversation to collaborators on Jul 10, 2020