Skip to content

Honor setting show only shortcut keys - #136251

Merged
João Moreno (joaomoreno) merged 3 commits into
microsoft:mainfrom
PEZ:screencast-honor-show-only-shortcuts
Nov 5, 2021
Merged

João Moreno (joaomoreno) merged 3 commits into
microsoft:mainfrom
PEZ:screencast-honor-show-only-shortcuts

Conversation

@PEZ

Copy link
Copy Markdown
Contributor

In the last changes of #126742 we made the setting screencastMode.onlyKeyboardShortcuts stop working. This reinstalls it.

CC: João Moreno (@joaomoreno)

@PEZ

Copy link
Copy Markdown
Contributor Author

This is still not right. Looking at it.

@PEZ

Copy link
Copy Markdown
Contributor Author

Now it works such that:

For screencastMode.onlyKeyboardShortcuts is false => show all keys pressed

ForscreencastMode.onlyKeyboardShortcuts is true, and we have a shortcut command =>

  • Format is keys => Show keys
  • Format is command => Show command title if we have it, otherwise keys (”same" for commandWithGroup)
  • Format is commandAndKeys => Show command + keys if we have a command title, otherwise just keys ("same" for commandWithGroupAndKeys)

What tripped us up was probably the settings semantics talking about shortcut, but in the implementation semantics that is a shortcut with a commandId. (I.e. the first part of a chord for a shortcut command is a shortcut.) I don't know what we should be calling it instead.

@joaomoreno

Copy link
Copy Markdown
Contributor

Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants