Repository navigation
133348 fix oom when search opened in editor - #136554
Merged
Jackson Kearl (JacksonKearl) merged 3 commits intoNov 9, 2021
Merged
Jackson Kearl (JacksonKearl) merged 3 commits into
Jackson Kearl (JacksonKearl) merged 3 commits into
Conversation
… - major memory optimization [2671Mb -> 220Mb] [1.9sec -> 1.6sec] usecase from microsoft#133348 (comment) file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
… - additional memory optimization [220Mb -> 15Mb] [1.6sec -> 2.2sec] Slightly slower due to gc calls usecase from microsoft#133348 (comment) file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
|
|
Contributor
Author
|
existed tests passed - https://github.com/Gvozd/vscode/actions/runs/1427942500 |
… - performance optimization[2.2sec -> 50ms] usecase from microsoft#133348 (comment) file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
Contributor
Author
|
third commit optimized time performance at x40 times on this usecase - from 2.2sec to ~50ms |
Jackson Kearl (JacksonKearl)
self-requested a review
November 9, 2021 00:21
Contributor
|
So speedy! Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #133348
reproduce steps: #133348 (comment)
I test my fixes on search in
plugins.pkgd.min.jsfrom https://github.com/froala/wysiwyg-editorbefore my fixes
Open in editorconsumed 2671MBafter first fix consumed 220MB
after second fix consumed ~15-30MB
