Skip to content

Fixes missing files when manually building vscode server - #137570

Merged
João Moreno (joaomoreno) merged 2 commits into
microsoft:mainfrom
jeanp413:fix-137568
Nov 24, 2021
Merged

João Moreno (joaomoreno) merged 2 commits into
microsoft:mainfrom
jeanp413:fix-137568

Conversation

@jeanp413

Copy link
Copy Markdown
Contributor

This PR fixes #137568

@alexdima Alexandru Dima (alexdima) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matt Bierner (@mjbvz) João Moreno (@joaomoreno) The suggested change looks good to me, but I would like to get approval from you as well. Here is what I can put together:

  • yarn extensions-ci is executed in the compilation phase
  • extensions-ci is a gulp task that executes both compileExtensionsBuildTask and compileExtensionMediaBuildTask
  • in gulpfile.vscode.reh.js, we would be calling in 1 place compileExtensionsBuildTask but not compileExtensionMediaBuildTask
  • similarly, in gulpfile.vscode.js we would be calling in 3 places compileExtensionsBuildTask, but not compileExtensionMediaBuildTask
  • this PR adds compileExtensionMediaBuildTask in 2 of the 4 places where compileExtensionsBuildTask was called

I plan that gulpfile.vscode.reh.js should do exactly what gulpfile.vscode.js does. So in this particular case, although issue #137568 talks about missing files in the server build, it looks like those files would be missing also in the vscode build (unless someone manually runs extensions-ci before).

I will therefore defer to you João Moreno (@joaomoreno) Matt Bierner (@mjbvz) to figure out what you want to do here and I am happy to take whatever you do also in gulpfile.reh.js.

@joaomoreno

Copy link
Copy Markdown
Contributor

Thanks for the investigation Alexandru Dima (@alexdima). This is the correct change. The changes in gulpfile.vscode.js should've been made at the time compileExtensionMediaBuildTask was introduced.

The *-ci tasks are running only in our CI which is orchestrated in a way that extensions-ci is always going to be called before vscode-*-ci.

@joaomoreno

João Moreno (joaomoreno) commented Nov 24, 2021 •

Copy link
Copy Markdown
Contributor

Thanks Jean Pierre (@jeanp413) 🚀

@joaomoreno
João Moreno (joaomoreno) merged commit 556ce85 into microsoft:main Nov 24, 2021
@jeanp413
Jean Pierre (jeanp413) deleted the fix-137568 branch November 24, 2021 14:32
Geoffrey Gulotta (guibber) pushed a commit to guibber/vscode that referenced this pull request Nov 30, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing files when manually building vscode server

5 participants