Repository navigation
Fixes missing files when manually building vscode server - #137570
Conversation
Alexandru Dima (alexdima)
left a comment
There was a problem hiding this comment.
Matt Bierner (@mjbvz) João Moreno (@joaomoreno) The suggested change looks good to me, but I would like to get approval from you as well. Here is what I can put together:
yarn extensions-ciis executed in the compilation phaseextensions-ciis a gulp task that executes bothcompileExtensionsBuildTaskandcompileExtensionMediaBuildTask- in
gulpfile.vscode.reh.js, we would be calling in 1 placecompileExtensionsBuildTaskbut notcompileExtensionMediaBuildTask - similarly, in
gulpfile.vscode.jswe would be calling in 3 placescompileExtensionsBuildTask, but notcompileExtensionMediaBuildTask - this PR adds
compileExtensionMediaBuildTaskin 2 of the 4 places wherecompileExtensionsBuildTaskwas called
I plan that gulpfile.vscode.reh.js should do exactly what gulpfile.vscode.js does. So in this particular case, although issue #137568 talks about missing files in the server build, it looks like those files would be missing also in the vscode build (unless someone manually runs extensions-ci before).
I will therefore defer to you João Moreno (@joaomoreno) Matt Bierner (@mjbvz) to figure out what you want to do here and I am happy to take whatever you do also in gulpfile.reh.js.
|
Thanks for the investigation Alexandru Dima (@alexdima). This is the correct change. The changes in The |
|
Thanks Jean Pierre (@jeanp413) 🚀 |
This PR fixes #137568