Skip to content

Update latex language grammar and configuration - #140801

Merged
Alex Ross (alexr00) merged 3 commits into
microsoft:mainfrom
jlelong:jl/latex-basics
Jan 19, 2022
Merged

Alex Ross (alexr00) merged 3 commits into
microsoft:mainfrom
jlelong:jl/latex-basics

Conversation

@jlelong

Copy link
Copy Markdown
Contributor

This PR does 3 things

  1. Update the LaTeX language configuration to add big delimiters with |, \|, [lr][vV]ert, \langle...\rangle to bracket pairs. Related to

  2. Use the new markdown language configuration for the combined markdown-latex language

  3. Update the grammar files

Martin Aeschlimann (@aeschli) I guess this PR is for you. I hope I did it right.

@alexr00 Alex Ross (alexr00) left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! I've just updated the cgmanifest.json file.

For updating the syntax files: I usually run the script that updates them once per release. You are always welcome to make PRs to update them too, but if you don't feel like it then I'll update them eventually too!

@alexr00
Alex Ross (alexr00) merged commit 3e9acdd into microsoft:main Jan 19, 2022
@alexr00 Alex Ross (alexr00) added this to the January 2022 milestone Jan 19, 2022
@jlelong

Copy link
Copy Markdown
Contributor Author

Thank you for the pull request! I've just updated the cgmanifest.json file.

I thought I had updated it but I probably lost it somewhere. Thanks for taking care of this!

For updating the syntax files: I usually run the script that updates them once per release. You are always welcome to make PRs to update them too, but if you don't feel like it then I'll update them eventually too!

Yes. However, the build script only updates the grammar files but not the language configuration files. Hence, this PR. Basically, I will only make a PR when those language configuration files need to be updated.

@jlelong
Jerome Lelong (jlelong) deleted the jl/latex-basics branch January 19, 2022 10:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants