Repository navigation
Remove fakeroot wrapper, when building .rpm packages - #153249
Merged
Merged
Conversation
RPM packages are intended to be built by normal users, they don't require root permissions (even fake ones).
Frank Dana (ferdnyc)
force-pushed
the
rpm-no-fakeroot
branch
from
June 26, 2022 13:49
dc638e7 to
519b8c4
Compare
Contributor
|
I'm pretty sure this was needed when I set it up. Might be related to how our CI ran/runs. |
Daniel Imms (Tyriar)
assigned
Raymond Zhao (rzhao271) and unassigned
Daniel Imms (Tyriar)
Raymond Zhao (rzhao271)
approved these changes
Jun 28, 2022
Raymond Zhao (rzhao271)
left a comment
Raymond Zhao (rzhao271)
left a comment
Collaborator
There was a problem hiding this comment.
Ran a custom build and it seems to be fine.
Robo (deepak1556)
approved these changes
Jun 29, 2022
Robo (deepak1556)
left a comment
Robo (deepak1556)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but I recommend merging it in debt week since we are currently in testing phase of current iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REALLY minor change, but... there's no reason to use
fakerootwhen building RPMs. Unlike when building.debfiles, the.rpmpackaging process is intended to be performed by a regular, unprivileged user. It doesn't require root permissions (even fake ones), because installed-file permissions are stored as package metadata and applied when the package is extracted and installed.