Skip to content

Fix cannot specify custom path for built-in profiles on Windows - #175464

Merged
Daniel Imms (Tyriar) merged 6 commits into
microsoft:mainfrom
dan-petty:main
May 2, 2023
Merged

Daniel Imms (Tyriar) merged 6 commits into
microsoft:mainfrom
dan-petty:main

Conversation

@dan-petty

Copy link
Copy Markdown
Contributor

Fix paths misconfigured if build-in profile with same name exists

@dan-petty

Copy link
Copy Markdown
Contributor Author

#161219

@dan-petty

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@dan-petty

Copy link
Copy Markdown
Contributor Author

To test set a custom path for "Git Bash" profile in settings.json:

    "terminal.integrated.profiles.windows": {
        "Git Bash": {
            "path": "C:\\custom\\path\\to\\git\\bin\\bash.exe"
        }
    }

@dan-petty Daniel Petty (dan-petty) changed the title Update terminalProfiles.ts Fix cannot specify custom path for built-in profiles on Windows Feb 26, 2023

@Tyriar Daniel Imms (Tyriar) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a little trouble reproducing, I think because the git bash source picks up my install, but this fix looks good and safe 👍

@Tyriar Daniel Imms (Tyriar) added this to the April 2023 milestone Mar 29, 2023
auto-merge was automatically disabled May 2, 2023 21:56

Pull request was closed

@Tyriar
Daniel Imms (Tyriar) merged commit f4329b3 into microsoft:main May 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants