Skip to content

fixes issue #662 (enables Pointer Lock Web API) - #210875

Merged
Matt Bierner (mjbvz) merged 11 commits into
microsoft:mainfrom
whistlegraph:pointer-lock-in-webview
Apr 30, 2025
Merged

Matt Bierner (mjbvz) merged 11 commits into
microsoft:mainfrom
whistlegraph:pointer-lock-in-webview

Conversation

@whistlegraph

@whistlegraph @jeffrey on prompt.ac (whistlegraph) commented Apr 22, 2024 •

Copy link
Copy Markdown
Contributor

This change fixes microsoft/vscode-extension-samples#662
fixes #221593

By explicitly allowing the pointerLock permission in the root document of the VS Code window.

Testing

  • You can test this change using the aesthetic-computer.aesthetic-computer-code extension in the Marketplace.
  • Open the Aesthetic Computer pane from the Activity Bar.
  • Enter fps and press [Enter].
  • Press [Escape] to end the Pointer Lock.

Comment thread src/vs/code/electron-main/app.ts Outdated
@mjbvz Matt Bierner (mjbvz) added this to the July 2024 milestone Jul 12, 2024
@aeschli Martin Aeschlimann (aeschli) added the postponed-during-endgame Endgame champ removed the planed milestone label Feb 27, 2025
@mjbvz
Matt Bierner (mjbvz) merged commit 9244832 into microsoft:main Apr 30, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

postponed-during-endgame Endgame champ removed the planed milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointer lock doesn't work with webview panel in extension Please add a minimal sample for creating an LSP client.

6 participants