Repository navigation
Move shared process to a browser window - #21879
Conversation
| windowsMainService = accessor.get(IWindowsMainService); | ||
|
|
||
| windowsMainService.onWindowClose(() => { | ||
| if (windowsMainService.getWindowCount() === 0) { |
There was a problem hiding this comment.
João Moreno (@joaomoreno) as I said before, this should have a check for Windows/Linux, because only there we close the app when closing the last window!
Benjamin Pasero (bpasero)
left a comment
Benjamin Pasero (bpasero)
left a comment
There was a problem hiding this comment.
LGTM overall. Upon first looks I am not sure why the native crash on Windows happens. Would be interesting if the crash reproduces if the contents of that window are super simple (that would indicate it's an issue with the way the lifecycle of the window is handled).
| <script> | ||
| (function () { | ||
| try { | ||
| window.location.search.substring(1).split('&').forEach(p => { |
There was a problem hiding this comment.
Theming here?
There was a problem hiding this comment.
Yeah good catch, removing this.
| @@ -0,0 +1,102 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Seems like a lot of overlap with https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/bootstrap/index.js#L48, maybe better to have a common base that both can reuse?
|
Wow, that took a lot of commits. Thanks for the help, Benjamin Pasero (@bpasero) ! |
|
João Moreno (@joaomoreno) is the merge already in the latest insider build? |
5 participants
Moving the shared process to a browser window will enable it to use Chrome's network stack. This will affect mostly the extension viewlet.
Related to #18103