Repository navigation
config: Resolve variables returned by commands - #246641
Merged
Merged
Conversation
Two pass should no longer needed since non-interactive and contributed variables are also resolved by `resolveWithInteraction`
Connor Peet (connor4312)
approved these changes
Apr 16, 2025
Connor Peet (connor4312)
enabled auto-merge (squash)
April 16, 2025 16:44
Sandeep Somavarapu (sandy081)
approved these changes
Apr 16, 2025
Member
|
guiserle (@guiserle) thanks for the contribution! Should be good to go once you do the CLA 🙌 |
Contributor
Author
|
@microsoft-github-policy-service agree company="Analog Devices" |
Contributor
Author
|
Connor Peet (@connor4312) thanks for the quick review and approval. PS. It took a little while for my company to provide the approval, apologies for the delay on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246633
This PR fixes a regression on c22175d#diff-e482f7894e136562bb05760b6da7f5d40e4721aa06b1432c753cdec530d23850 that causes variables returned by commands not being resolved.
The proposed solution is expose
AbstractVariableResolverService.evaluateSingleVariableto child classes soBaseConfigurationResolverServicecan use the default resolution method for any variable nested within a command or input variable.