Skip to content

#245665 fix early task exit with empty promptString input - #246834

Merged
Megan Rogge (meganrogge) merged 1 commit into
microsoft:mainfrom
johnscollins98:fix-empty-prompt-string
Apr 21, 2025
Merged

Megan Rogge (meganrogge) merged 1 commit into
microsoft:mainfrom
johnscollins98:fix-empty-prompt-string

Conversation

@johnscollins98

@johnscollins98 John Collins (johnscollins98) commented Apr 17, 2025 •

Copy link
Copy Markdown
Contributor

address issue #245665

tested with the following tasks.json file:

{
  "version": "2.0.0",
  "tasks": [
    {
      "command": "echo",
      "label": "echo",
      "args": [
        "${input:test1}",
        "${input:test2}"
      ]
    }
  ],
  "inputs": [
    {
      "id": "test1",
      "type": "promptString",
      "default": "",
      "description": "test1"
    },
    {
      "id": "test2",
      "type": "promptString",
      "default": "",
      "description": "test2"
    }
  ]
}

entering empty strings into the prompts, before my change it ends early after test1 after it goes all the way through to echo both inputs

@meganrogge Megan Rogge (meganrogge) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meganrogge Megan Rogge (meganrogge) added this to the April 2025 milestone Apr 17, 2025
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) April 21, 2025 13:48
@meganrogge
Megan Rogge (meganrogge) merged commit 6167324 into microsoft:main Apr 21, 2025
@johnscollins98
John Collins (johnscollins98) deleted the fix-empty-prompt-string branch April 21, 2025 16:49
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants