Repository navigation
Expand docs on the side in the suggest widget - #25812
Merged
Merged
Conversation
|
Ramya Rao (@ramya-rao-a), thanks for your PR! By analyzing the history of the files in this pull request, we identified João Moreno (@joaomoreno) and Johannes Rieken (@jrieken) to be potential reviewers. |
This was referenced May 4, 2017
Contributor
|
I'll file individual issues for the problems I find. |
This was referenced May 4, 2017
João Moreno (joaomoreno)
left a comment
Contributor
There was a problem hiding this comment.
Code looks OK. I filed a few issues. Nothing blocking in my opinion, just a lot of tweaking. I'll leave the merge decision up to you.
| height: 100%; | ||
| width: 100%; | ||
| width: 40%; | ||
| float: left; |
Contributor
There was a problem hiding this comment.
Careful with floats. If all you have is two divs, you should use the usual inline-block display to lay them out side by side.
Closed
39 of 44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft for #18582
Features in the PR:
suggestion.detailsorsuggestion.documentationexist, they will appear on the side of the suggest list. If no docs but details match then label, then the docs section is not shownctrl+spaceand then page up and down as usualPending:
Update as of 5/7: Logic to decide when to swap list and docs, where to position the suggest widget and when to re-size the docs is finalized here: https://github.com/Microsoft/vscode/blob/ramyar/docs-on-the-side/src/vs/editor/contrib/suggest/browser/suggestWidget.ts#L817