Repository navigation
Fixes editor has wrong height when toggling tabs with breadcrumbs visible - #97502
Merged
Merged
Conversation
Jean Pierre (jeanp413)
force-pushed
the
fix-97021
branch
from
May 11, 2020 13:36
fe80ba8 to
2fdc9d7
Compare
Jean Pierre (jeanp413)
marked this pull request as draft
May 11, 2020 13:50
Jean Pierre (jeanp413)
marked this pull request as ready for review
May 11, 2020 14:47
Contributor
|
Thanks. I made changes on top to make this simpler: instead of calling layout from redraw, simply relayout when we detect the options change. |
Contributor
Author
|
Awesome, much better 👍 vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts Lines 195 to 200 in 613bcf2 |
Contributor
|
Jean Pierre (@jeanp413) not sure. the code I touched handles the transition between tabs being enabled or not while that method is about enabling breadcrumbs or not. I still think both cases need layout calls individually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #97021