Repository navigation
feat: implement colour contributions for debug REPL - #97762
Conversation
|
Robert Rossmann (@robertrossmann) great PR as usual! Thanks a lot π
Adding Martin Aeschlimann (@aeschli) as a reviewer for color names |
|
Thanks for pushing this. Would be great to eventually have all of debug be fully themable π |
|
Isidor Nikolic (@isidorn) Thanks for the suggestions! I will drop I'll rename the colour scope to |
|
Isidor Nikolic (@isidorn) updated now, with some deviations noted below. βΉοΈ
Let me know what you think. β€οΈ |
|
Thanks a lot. Your changes look great thus approving. Though let's wait just for Martin Aeschlimann (@aeschli) to approve the color names and then we can merge this. |
|
Robert Rossmann (@robertrossmann) after discussing with Martin Aeschlimann (@aeschli) we like all the color names except |
|
Isidor Nikolic (@isidorn) Updated! β |
|
Looks great. Thanks for doing this. Merging in π |
# [4.14.0](4.13.0...4.14.0) (2020-05-18) ### Features * add debug Console colour contributions π¨ ([9cd02be](9cd02be)), closes [microsoft/vscode#97762](microsoft/vscode#97762) * customise colours for Test Explorer UI π¨ ([0d0568f](0d0568f)), closes [hbenl/vscode-test-explorer#132](hbenl/vscode-test-explorer#132)
This PR fixes #97695.
Most of the debug REPL components are now theme-able. π π¨ The following new colour contributions have been added:
debugConsole.infoForeground: info-level messagesdebugConsole.warningForeground: warning-level messagesdebugConsole.errorForeground: error-level messagesdebugConsole.sourceForeground: foreground colour of the source filename which generated the log messagedebugConsoleInputIcon.foreground: icon colour which marks the evaluation input. I remember seeing a very specific name for this icon but I cannot remember. I will happily update the naming of this contribution to match if this is not accurate.Chores
I have moved the theming support for REPL out of the
repl.tsfile so we have it in one place.