Repository navigation
fix: map android ToggleButton to switch role and fix stale locator docs - #256
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: π Files selected for processing (1)
π§ Files skipped from review as they are similar to previous changes (1)
WalkthroughThe switch role mapping now recognizes π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getByRole('switch')didn't matchandroid.widget.ToggleButtoneven though the locators doc claimed it did βROLE_TYPE_MAP.switchhad an unreachable'toggle'entry instead of'togglebutton'. Added the correct entry.TextViewis filtered out before reaching the query engine; mobilecli'sacceptedTypes(pinned at 0.3.89) already surfaces it, so the doc was stale.AppCompatButton,MaterialButton,FloatingActionButton,AppCompatEditText,TextInputEditText,AppCompatTextView,MaterialTextView,AppCompatImageView,ShapeableImageView) thatROLE_TYPE_MAPalready recognized but the docs never listed.Test plan
ToggleButtoncase to the existing "fully-qualified native types" test suite inquery-engine.test.ts, confirmed it passes:npx playwright test --config=tests/mobilewright.config.ts packages/mobilewright-core/src/query-engine.test.ts -g "switch role"npm run lintpasses