Repository navigation
fix: log why device allocation silently waits when no device matches - #313
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: π Files selected for processing (2)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Walkthrough
Priority: β¬οΈ Low π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When no local device matches the allocation criteria (offline, name/id/type/osVersion mismatch), the mobilecli allocator throws
NoDeviceAvailableErrorand the device pool silently re-queues the waiter. With a single local device nothing ever releases, so the test hangs with the last log line beingmw:driver-mobilecli found 1 device(s).mw:driver-mobilecli: on no match, log criteria, taken ids, and each device's id/name/state/type/osVersionmw:device-pool(new namespace): log when a waiter is re-queuedTest plan
npm run buildDEBUG=mw:*, confirm the mismatch is visible