Repository navigation
fix: honour DO_NOT_TRACK and require node >=22.12.0 in every package - #326
Merged
Merged
Conversation
- telemetry and the Scarf pixel are disabled when MOBILEWRIGHT_DISABLE_TELEMETRY or DO_NOT_TRACK (anything except 0/false) is set - document telemetry: README section and new docs/guides/telemetry page - all workspace packages declare engines.node >=22.12.0 (7 still said >=20.19)
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 3 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 3 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 23 minutes for your next included review. Limit details: You’ve used all 3 included reviews currently available. Your 47 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Comment |
gmegidish
force-pushed
the
fix/telemetry-and-engines
branch
from
September 17, 2026 10:14
3b859d9 to
bd22d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOBILEWRIGHT_DISABLE_TELEMETRYis set (any value, unchanged) or the standardDO_NOT_TRACKis set to anything except0/false. When disabled, no identifier file is created and no requests are made.MOBILEWRIGHT_DISABLE_TELEMETRY,DO_NOT_TRACKandDEBUGlisted under "Environment variables" indocs/src/getting-started/running-tests.md.mobilewrightand the repo root already required>=22.12.0, but@mobilewright/test,core,protocol,driver-mobilecli,driver-mobilenext,inspectorandclistill declared>=20.19. All packages (and their lockfile entries) now declare>=22.12.0, matchingdoctor's check.Test plan
packages/mobilewright/src/telemetry.test.ts: enabled by default;MOBILEWRIGHT_DISABLE_TELEMETRYany value;DO_NOT_TRACK1/true/yes disables; 0/false/empty keeps enablednpm run build,npm run lint