Repository navigation
In the case of remounting with changed data, need to call mount - #34077
Merged
Merged
Conversation
Contributor
Author
|
cc @cyli can you test if this resolves your issue? |
Contributor
|
@justincormack Yes, this does correctly remount the secrets dir, thanks! |
Contributor
|
Lacks some unit test or so to avoid future regressions, no? |
Member
Contributor
Author
|
@shouze yes, the current test setup does not really work for this, only for bind mounts, I will add some other tests. |
justincormack
force-pushed
the
mount_remount_opts
branch
from
July 13, 2017 14:39
f1446c2 to
88e3289
Compare
Contributor
Author
|
Added a test that will cover this case. |
The case where we are trying to do a remount with changed filesystem specific options was missing, we need to call `mount` as well here to change those options. See moby#33844 for where we need this, as we change `tmpfs` options. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
mount_remount_opts
branch
from
July 13, 2017 14:49
88e3289 to
3a1ab5b
Compare
estesp
approved these changes
Jul 13, 2017
estesp
left a comment
estesp
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Sorry I didn't see the original issue; I would have guessed first it was about changing mount options as I fought with that so many times when first doing the userns implementation :-]
Contributor
Author
|
cc @cpuguy83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case where we are trying to do a remount with changed filesystem specific options was missing,
we need to call
mountas well here to change those options.See #33844 for where we need this, as we change
tmpfsoptions.Signed-off-by: Justin Cormack justin.cormack@docker.com