Repository navigation
Fix deprecation of "error" and "progress" fields in streaming responses - #49447
Merged
Merged
Conversation
vvoland
approved these changes
Feb 11, 2025
Member
Author
|
DERP; probably trailing whitespace in YAML; let me check |
Member
Author
|
OH! Nope; looks like we're generating some type from the swagger for one of these; |
Member
Author
|
Ignore me; probably just needs a rebase looking at that error |
thaJeztah
force-pushed
the
jsonmessage_fix_deprecation
branch
from
February 11, 2025 14:41
929ec7d to
ba5e67e
Compare
thaJeztah
force-pushed
the
jsonmessage_fix_deprecation
branch
from
February 11, 2025 15:29
ba5e67e to
56a6383
Compare
austinvazquez
approved these changes
Feb 11, 2025
Member
Author
|
Yay! For those wanting to know; after fixing the first error... it was whitespace after all! I ran So some follow-up PR incoming as well 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/jsonmessage: JSONMessage: fix deprecation of ProgressMessage, ErrorMessage
which was part of docker v0.6.0 / API v1.4
which was part of docker v0.7.1 / API v1.8
api: deprecation of "error" and "progress" fields in streaming responses
which was part of docker v0.6.0 / API v1.4
which was part of docker v0.7.1 / API v1.8
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)