Repository navigation
Fix/vue3 followup - #8822
Merged
Merged
Fix/vue3 followup#8822
Conversation
This syntax seems to be supported by Vue2 but no longer by Vue3. It's redundant anyway as the used components CollaborativeEditorApp und MarkdownContentEditorApp already have `ref="editor-container"`. Fixes "[Vue warn]: Missing ref owner context. ref cannot be used on hoisted vnodes. A vnode with ref must be created inside the render function." Signed-off-by: Jonas <jonas@freesources.org>
…nmount The editor might already be destroyed on unmount. Fixes "[tiptap error]: The editor view is not available. Cannot access view['dom']. The editor may not be mounted yet." Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
Signed-off-by: Jonas <jonas@freesources.org>
github-project-automation
Bot
moved this from 🧭 Planning evaluation (don't pick)
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)