Remove circular dependency in code cache and snapshot building

This issue tracks this TODO in node.gyp (which was originally for the code cache builder, but we also need something similar for the snapshot builder)

node/node.gyp

Lines 1176 to 1181 in db109e8

    
           # TODO(joyeecheung): do not depend on node_lib, 
        
           # instead create a smaller static library node_lib_base that does 
        
           # just enough for node_native_module.cc and the cache builder to 
        
           # compile without compiling the generated code cache C++ file. 
        
           # So generate_code_cache -> mkcodecache -> node_lib_base, 
        
           #    node_lib -> node_lib_base & generate_code_cache

Removing the current circular dependency in the two-step builds should make this building process less error-prone.

Previous refs:

#27431
#30647

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Navigation Menu

Repository navigation

Remove circular dependency in code cache and snapshot building #31074

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	# TODO(joyeecheung): do not depend on node_lib,
	# instead create a smaller static library node_lib_base that does
	# just enough for node_native_module.cc and the cache builder to
	# compile without compiling the generated code cache C++ file.
	# So generate_code_cache -> mkcodecache -> node_lib_base,
	# node_lib -> node_lib_base & generate_code_cache

Remove circular dependency in code cache and snapshot building #31074

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions