Cannot make a node-fetch request, TypeError: Cannot read property 'Symbol(requestOptions)' of undefined #36364

Activity

1. RaisinTen commented on Dec 3, 2020

   

   RaisinTen

   on Dec 3, 2020

   Member

   More actions

   I'm having some difficulty reproducing this:

   ❯ cat index.js

   const fetch = require('node-fetch');
   
   (async () => {
   	const response = await fetch('https://api.github.com/users/github');
   	const json = await response.json();
   
   	console.log(json);
   })();

   ❯ node index.js &> /dev/null
   ❯ echo $?
   0
   ❯ node -v
   v15.2.0
   ❯ uname -a
   Linux hp 4.15.0-124-generic #127-Ubuntu SMP Fri Nov 6 10:54:24 UTC 2020 i686 i686 i686 GNU/Linux

   As you can see, it exits with a zero error code.
2. seven-deuce commented on Dec 4, 2020

   

   seven-deuce

   on Dec 4, 2020

   Author

   More actions

   I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
   When I removed it, it all started to work,
   I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??
3. targos

   self-assigned this

   on Dec 6, 2020
4. targos

   added

   httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.

   on Dec 6, 2020
5. targos

   removed their assignment

   on Dec 6, 2020
6. targos

   added a commit that references this issue on Dec 7, 2020

   http: use objects with null prototype in Agent

   ...

   a971179
7. Trott commented on Dec 9, 2020

   

   Trott

   on Dec 9, 2020

   Member

   More actions

   I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
   When I removed it, it all started to work,
   I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??

   This may be due to expanded use of what we call primordials on the project. The idea is that if a user changes the Object prototype, it should affect their code but not Node.js internal code. This is a security precaution but it may cause difficulty for people who "monkey-patch" Node.js internals like AMP vendors. I'd be curious to know what library is exhibiting this problem so we can track down whether this is expected breakage or a bug in Node.js that we need to fix.
8. Trott commented on Dec 9, 2020

   

   Trott

   on Dec 9, 2020

   Member

   More actions

   I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
   When I removed it, it all started to work,
   I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??

   This may be due to expanded use of what we call primordials on the project. The idea is that if a user changes the Object prototype, it should affect their code but not Node.js internal code. This is a security precaution but it may cause difficulty for people who "monkey-patch" Node.js internals like AMP vendors. I'd be curious to know what library is exhibiting this problem so we can track down whether this is expected breakage or a bug in Node.js that we need to fix.

   Though it looks like @targos has already self-assigned this so they probably have a good idea what the bug is and what the fix is.

   👍React with 👍1Reacted by Mehdi
9. targos commented on Dec 9, 2020

   

   targos

   on Dec 9, 2020

   Member

   More actions

   #36409 and #36410 are the pull requests that fix this issue. I referenced the issue in the PRs but forgot to do the opposite here, sorry!
10. targos commented on Dec 9, 2020

    

    targos

    on Dec 9, 2020

    Member

    More actions

    To explain the bug: there was a semver-minor change that introduced a for ... in loop on the requests property of http Agent.
    If enumerable properties were added to Object.prototype, they would be iterated by this loop, triggering this bug because they probably wouldn't have an object at index 0.

    👍React with 👍1Reacted by Mehdi

    ❤️React with ❤️1Reacted by Mehdi
11. targos

    closed this as completedin 2ef9a76on Dec 13, 2020
12. targos

    added a commit that references this issue on Dec 13, 2020

    http: do not loop over prototype in Agent

    ...

    9852ebc
13. BethGriggs

    added a commit that references this issue on Feb 8, 2021

    http: do not loop over prototype in Agent

    ...

    017eed6
14. ruyadorno

    added 2 commits that reference this issue on Feb 8, 2021

    http: do not loop over prototype in Agent

    ...

    9a9cf1e

    http: do not loop over prototype in Agent

    ...

    cd9a810
15. MayaLekova

    added a commit that references this issue on May 22, 2026

    http: use objects with null prototype in Agent

    ...

    2ef9a76