make check failure for macOS arch64 #36656
Description
Commit 0b6d307
macOS 11.1 aarch64
Xcode 12.3
make; make check
=== release test-worker-prof ===
Path: sequential/test-worker-prof
node:assert:119
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: child exited with signal: {
status: null,
signal: 'SIGSEGV',
output: [ null, '', '' ],
pid: 73280,
stdout: '',
stderr: ''
}
at Object.<anonymous> (/Users/USERNAME/github/node/test/sequential/test-worker-prof.js:58:10)
at Module._compile (node:internal/modules/cjs/loader:1108:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
at Module.load (node:internal/modules/cjs/loader:973:32)
at Function.Module._load (node:internal/modules/cjs/loader:813:14)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
at node:internal/main/run_main_module:17:47 {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: 'SIGSEGV',
expected: null,
operator: 'strictEqual'
}
Command: out/Release/node /Users/USERNAME/github/node/test/sequential/test-worker-prof.js
[02:41|% 100|+ 3282|- 1]: Done
make[1]: *** [jstest] Error 1
make: *** [test] Error 2
Activity
PoojaDurgad commentedon Dec 28, 2020
@chadbrewbaker - personally I have not used macos but
make checkworks fine for windows10 ostargos commentedon Dec 28, 2020
I don't know if we have collaborators with an M1 Mac yet.
aduh95 commentedon Dec 28, 2020
I can reproduce on my machine (M1 CPU).
aduh95 commentedon Jan 4, 2021
For info,
node --profalways segfaults on Apple Silicon, it's probably a V8 bug. If you don't need this feature,nodeworks perfectly fine though.I'm not able to compile
gdbthough, so I can't really help debug this, sorry.targos commentedon Jan 4, 2021
Maybe you can try
lldbinstead?aduh95 commentedon Jan 4, 2021
lldbgave me the info I needed 👍I've submitted the fix to https://chromium-review.googlesource.com/c/v8/v8/+/2609413. @nodejs/v8 is there something else I should do to ensure the fix makes it to the next Node.js releases?
targos commentedon Jan 26, 2021
@aduh95 If you want someone to review your CL, you need to mark it as ready for review (it's currently WIP) and ideally add some reviewers.
Edit: it's a bit counter-intuitive, but that's what the "Start review" button allows you to do.
aduh95 commentedon Jan 26, 2021
@targos Thanks for the info! I've now submitted the CL for reviews.
mhdawson commentedon Feb 17, 2021
@hashseed can you help get a review of the PR in the V8 changed needed before we can enable testing in the Node.js CI?
[aarm64] Fix GetSharedLibraryAddresses
deps: V8: cherry-pick 8957d4677aa7
deps: V8: cherry-pick 8957d4677aa7
deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream
deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream
[aarm64] Fix GetSharedLibraryAddresses
deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream