Skip to content

Tests take a long time to run #47146

Closed as not planned
Closed as not planned
Tests take a long time to run#47146
Labels
staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@targos
targos
opened on Mar 18, 2023

There was a time (not so long a go, maybe ~1 year) when make -s jstest took 2-3 minutes on my previous computer.
Now I have a decent Mac with M2 Pro and the same command takes 8 minutes! I don't know what changed, but I doubt we more than doubled the number of tests since then.
Are there some relatively new tests which are specifically slow?

Activity

  1. Imagetargos
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Mar 18, 2023

  2. RaisinTen commented on Mar 20, 2023

    @RaisinTen
    RaisinTen
    on Mar 20, 2023
    Member

    test/parallel/test-single-executable-application.js has been added recently and it's a slow test. On my Intel Mac, it runs for ~38 seconds but I would expect it to be a bit faster on M2 Pro.

  3. bnoordhuis commented on Mar 20, 2023

    @bnoordhuis
    bnoordhuis
    on Mar 20, 2023
    Member

    The test runner unfortunately doesn't have an option to print the running time of individual tests but lowering the timeout (default is 120 seconds) will identify the slow ones:

    $ python tools/test.py -J --timeout 5 parallel

  4. richardlau commented on Mar 20, 2023

    @richardlau
    richardlau
    on Mar 20, 2023
    Member

    test-webcrypto takes over a minute to run on my system.

  5. targos commented on Mar 20, 2023

    @targos
    targos
    on Mar 20, 2023
    MemberAuthor
    $ python tools/test.py -J --timeout 5
=== release test-http-server-headers-timeout-keepalive ===
Path: parallel/test-http-server-headers-timeout-keepalive
Command: out/Release/node /Users/mzasso/git/nodejs/node/test/parallel/test-http-server-headers-timeout-keepalive.js
--- TIMEOUT ---


=== release test-http-server-request-timeout-keepalive ===
Path: parallel/test-http-server-request-timeout-keepalive
Command: out/Release/node /Users/mzasso/git/nodejs/node/test/parallel/test-http-server-request-timeout-keepalive.js
--- TIMEOUT ---


=== release test-single-executable-application ===
Path: parallel/test-single-executable-application
Command: out/Release/node /Users/mzasso/git/nodejs/node/test/parallel/test-single-executable-application.js
--- TIMEOUT ---


[04:11|% 100|+ 3721|-   3]: Done

    $ time ./node test/parallel/test-http-server-headers-timeout-keepalive.js
./node test/parallel/test-http-server-headers-timeout-keepalive.js  0.11s user 0.02s system 0% cpu 15.088 total
$ time ./node test/parallel/test-http-server-request-timeout-keepalive.js
./node test/parallel/test-http-server-request-timeout-keepalive.js  0.11s user 0.02s system 0% cpu 15.090 total
$ time ./node test/parallel/test-single-executable-application.js
./node test/parallel/test-single-executable-application.js  18.78s user 0.53s system 98% cpu 19.641 total

    $ make -s jstest

...

[05:27|% 100|+ 3878|-   0]: Done

All tests passed.

    Full run took 5m30s this time. Quite far from the 8 minutes I got last time 🤔

  6. joyeecheung commented on Mar 27, 2023

    @joyeecheung
    joyeecheung
    on Mar 27, 2023
    Member

    I think #44342 should help this a bit (which should enable us to move these sequential tests to parallel, but I haven't checked locally yet)

  7. joyeecheung commented on Mar 27, 2023

    @joyeecheung
    joyeecheung
    on Mar 27, 2023
    Member

    I opened #47274 (superseding #44342), which locally cut the time by 19s

  8. Imagenodejs-github-bot
    added a commit that references this issue on Mar 31, 2023

    test: run WPT files in parallel again

    c05689e
  9. Imagejoyeecheung
    added 3 commits that reference this issue on Apr 4, 2023

    test: run doctool tests in parallel

    cd36f6e

    test: use --port=0 in debugger tests that do not have to work on 9229

    967779b

    test: move debugger tests with --port=0 to parallel

    812e236
  10. ImageRafaelGSS
    added 4 commits that reference this issue on Apr 5, 2023

    test: run WPT files in parallel again

    f756906

  11. 28 remaining items

  12. Imagedanielleadams
    added 5 commits that reference this issue on Jul 6, 2023

    test: move debugger tests with --port=0 to parallel

    43d1601

    test: use random port in NodeInstance.startViaSignal()

    4af86be

    test: use random port in test-inspector-debug-brk-flag

    a437e4b

    test: use random port in test-inspector-enabled

    8fda55e

    test: move more inspector sequential tests to parallel

    61e0319
  13. ImageMoLow
    added 7 commits that reference this issue on Jul 6, 2023

    test: run doctool tests in parallel

    3c157cb

    test: use --port=0 in debugger tests that do not have to work on 9229

    016b8bd

    test: move debugger tests with --port=0 to parallel

    116df2a

    test: use random port in NodeInstance.startViaSignal()

    a2e4643

    test: use random port in test-inspector-debug-brk-flag

    e97ceec

    test: use random port in test-inspector-enabled

    f6ef5c4

    test: move more inspector sequential tests to parallel

    8820d54

  14. github-actions commented on Jun 15, 2026

    @github-actions
    github-actionsbot
    on Jun 15, 2026 – with GitHub Actions
    Contributor

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

  15. Imagegithub-actions
    added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jun 15, 2026
  16. Imagetargos
    closed this as not plannedon Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions