Flaky test-stream-readable-unpipe-resume #54133

Activity

1. targos

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   on Jul 31, 2024
2. github-actions

   added

   linuxIssues and PRs related to the Linux platform.Issues and PRs related to the Linux platform.

   on Jul 31, 2024
3. targos commented on Aug 1, 2024

   

   targos

   on Aug 1, 2024

   MemberAuthor

   More actions

   Stress test: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/520/
4. lpinca commented on Sep 11, 2024

   

   lpinca

   on Sep 11, 2024

   Last edited by lpinca

   Member

   More actions

   I can reproduce on Ubuntu.

   diff --git a/test/parallel/test-stream-readable-unpipe-resume.js b/test/parallel/test-stream-readable-unpipe-resume.js
   index b40f724bcc..3eeae52f5f 100644
   --- a/test/parallel/test-stream-readable-unpipe-resume.js
   +++ b/test/parallel/test-stream-readable-unpipe-resume.js
   @@ -13,7 +13,9 @@ const transformStream = new stream.Transform({
      })
    });
    
   -readStream.on('end', common.mustCall());
   +readStream.on('end', common.mustCall(function () {
   +  console.log('end');
   +}));
    
    readStream
      .pipe(transformStream)
   

   $ ./tools/test.py --repeat=10000 test/parallel/test-stream-readable-unpipe-resume
   === release test-stream-readable-unpipe-resume ===
   Path: parallel/test-stream-readable-unpipe-resume
   end
   Command: out/Release/node /home/luigi/node/test/parallel/test-stream-readable-unpipe-resume.js
   --- TIMEOUT ---
   
   
   [05:21|% 100|+ 9999|-   1]: Done
   
   Failed tests:
   out/Release/node /home/luigi/node/test/parallel/test-stream-readable-unpipe-resume.js
   

   This is yet another case (see #52550 (comment)) where the test correctly finishes (note "end" in the output) but the process does not exit.
5. targos commented on Sep 11, 2024

   

   targos

   on Sep 11, 2024

   MemberAuthor

   More actions

   I wish we were able to reproduce these more reliably, because I don't know how to debug something that only happens once or twice every 10k runs!

   👍React with 👍1Reacted by Luigi Pinca
6. lpinca commented on Sep 11, 2024

   

   lpinca

   on Sep 11, 2024

   Last edited by lpinca

   Member

   More actions

   It might be only a coincidence or a reduced failure rate, but even in this case I get no failures with the --jitless flag.
7. avivkeller commented on Oct 15, 2024

   

   avivkeller

   on Oct 15, 2024

   Last edited by avivkeller

   Member

   More actions

   Hypothetically, as a short-term solution, we could call process.exit() from these tests, but that acts like a bandaid, and not a patch.

   - readStream.on('end', common.mustCall());
   + readStream.on('end', common.mustCall(() => process.exit()));
8. lpinca commented on Oct 15, 2024

   

   lpinca

   on Oct 15, 2024

   Member

   More actions

   @redyetidev it does not help, see #52964 (comment).

   👍React with 👍1Reacted by Aviv Keller
9. avivkeller commented on Oct 17, 2024

   

   avivkeller

   on Oct 17, 2024

   Member

   More actions

   Insterestingly, it seems to not fail if you change the line to:

   readStream.on('end', common.mustCall(() => queueMicrotask(process.exit)));

   I ran 10,000 runs with this change: 0 failures
   I ran 2,000 runs without this change: 4 failures

   Although this could be a coincidence?
10. lpinca commented on Oct 17, 2024

    

    lpinca

    on Oct 17, 2024

    Last edited by lpinca

    Member

    More actions

    Although this could be a coincidence?

    Yes, I think so. For example, this

    diff --git a/test/parallel/test-net-write-fully-async-hex-string.js b/test/parallel/test-net-write-fully-async-hex-string.js
    index 37b5cd75c1..b37f2acefc 100644
    --- a/test/parallel/test-net-write-fully-async-hex-string.js
    +++ b/test/parallel/test-net-write-fully-async-hex-string.js
    @@ -30,3 +30,7 @@ const server = net.createServer(common.mustCall(function(conn) {
         writeLoop();
       }));
     }));
    +
    +server.on('close', function () {
    +  queueMicrotask(process.exit);
    +});
    

    makes no difference.
11. avivkeller commented on Oct 17, 2024

    

    avivkeller

    on Oct 17, 2024

    Member

    More actions

    This whole issue is strange. I wonder what task is hanging the process 🤔
12. github-actions commented on Apr 29, 2026

    

    github-actionsbot

    on Apr 29, 2026 – with GitHub Actions

    Contributor

    More actions

    This issue has been marked as stale due to 210 days of inactivity.
    It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
13. github-actions

    added

    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

    on Apr 29, 2026
14. github-actions commented on May 30, 2026

    

    github-actionsbot

    on May 30, 2026 – with GitHub Actions

    Contributor

    More actions

    This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
    If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
15. github-actions

    closed this as not plannedon May 30, 2026