Repository navigation
py3k: corrections for test_subprocess on windows #45388
Description
| BPO | 1047 |
|---|---|
| Nosy | @gvanrossum, @amauryfa, @tiran |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2007-11-09.01:36:47.516>
created_at = <Date 2007-08-28.22:33:09.520>
labels = ['interpreter-core', 'OS-windows']
title = 'py3k: corrections for test_subprocess on windows'
updated_at = <Date 2007-11-09.01:36:47.491>
user = 'https://github.com/amauryfa'bugs.python.org fields:
activity = <Date 2007-11-09.01:36:47.491>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2007-11-09.01:36:47.516>
closer = 'christian.heimes'
components = ['Interpreter Core', 'Windows']
creation = <Date 2007-08-28.22:33:09.520>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['8347', '8348', '8349']
hgrepos = []
issue_num = 1047
keywords = ['patch']
message_count = 4.0
messages = ['55384', '55385', '55429', '57293']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'amaury.forgeotdarc', 'christian.heimes']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1047'
versions = ['Python 3.0']
Activity
amauryfa commentedon Aug 28, 2007
I join three patches for py3k on Windows:
1/ getargs.diff adds the 'Z' and 'Z#' format specifiers for
PyArg_ParseTuple. They mimic z and z# for unicode strings, by accepting
a Unicode or None (in which case the Py_UNICODE* pointer is set to
NULL). With doc and tests.
2/ subprocess.diff converts file PC/_subprocess.c to unicode. We use the
Unicode version of the win32 api (and Z conversion from previous patch)
3/ stdout.diff: sys.stdout must not convert the line endings, Windows
already does it.
Without this patch, when redirecting the output of python, the file
contains \r\r\n for each line. (test_subprocess did catch this)
amauryfa commentedon Aug 28, 2007
Did I say that test_subprocess now passes on windows?
gvanrossum commentedon Aug 29, 2007
Committed revision 57669.
I have no way to test this so you'll have to watch the buildbot.
However, I didn't include the patch to _fileio.c that prevents closing
fds 0, 1, 2; I think that's the wrong thing to do and if it causes
problems it needs to be addressed in a different way.
tiran commentedon Nov 9, 2007
The patch to _fileio was implemented in a different way and applied to
the py3k branch a while ago.