Skip to content

rustc 1.83 lexing regression in the 2015 edition: 'r#x'y #133479

Closed
#133482
Closed
rustc 1.83 lexing regression in the 2015 edition: 'r#x'y#133479
#133482
Labels
A-parserArea: The lexing & parsing of Rust source code to an ASTC-bugCategory: This is a bug.P-mediumMedium priorityregression-untriagedUntriaged performance or correctness regression.

Description

@mattheww
mattheww
opened on Nov 25, 2024

rustc 1.82 accepts forms like 'r#x'y in the 2015 edition, but rustc 1.83 (beta) rejects them.

As I understand it, #126452 wasn't intended to have any effect on the 2015 edition.

playground

macro_rules! lexes {($($_:tt)*) => {}}

fn main() {
    lexes!('r#x'y);
}

I think this is fallout from the beta-backport of #132341.

Activity

  1. Imagemattheww
    added
    C-bugCategory: This is a bug.
    regression-untriagedUntriaged performance or correctness regression.
    on Nov 25, 2024
  2. Imagerustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Nov 25, 2024

  3. compiler-errors commented on Nov 26, 2024

    @compiler-errors
    compiler-errors
    on Nov 26, 2024
    Contributor

    I'm tempted to say that this is a purely theoretical regression, and we should perhaps fix it in 1.84 but it's possibly a bit too late for 1.83? Especially because I'm not certain how to prepare a fix for this other than perhaps reverting raw lifetime functionality altogether.

  4. Imagesaethlin
    removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Nov 26, 2024
  5. Imagecompiler-errors
    added
    A-parserArea: The lexing & parsing of Rust source code to an AST
    on Nov 26, 2024

  6. apiraino commented on Nov 26, 2024

    @apiraino
    apiraino
    on Nov 26, 2024
    Contributor

    WG-prioritization assigning priority (Zulip discussion).

    @rustbot label -I-prioritize +P-medium

  7. Imagerustbot
    added
    P-mediumMedium priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Nov 26, 2024
  8. Imagematthiaskrgr
    added 2 commits that reference this issue on Dec 1, 2024

    Rollup merge of rust-lang#133482 - compiler-errors:raw-lt-tick, r=est…

    9f7755e

    Rollup merge of rust-lang#133482 - compiler-errors:raw-lt-tick, r=est…

    337c48c
  9. Imagebors
    closed this as completedin 337c48con Dec 1, 2024
  10. Imagerust-timer
    added a commit that references this issue on Dec 1, 2024

    Unrolled build for rust-lang#133482

    564fba7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-parserArea: The lexing & parsing of Rust source code to an ASTC-bugCategory: This is a bug.P-mediumMedium priorityregression-untriagedUntriaged performance or correctness regression.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions