std::vec::IntoIter::as_mut_slice borrows &self, returns &mut of contents. #39465

Activity

1. steveklabnik

   added

   A-libs

   I-nominated

   I-unsoundIssue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/SoundnessIssue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   on Feb 2, 2017
2. brson commented on Feb 2, 2017

   

   brson

   on Feb 2, 2017

   Contributor

   More actions

   Awesome!
3. brson commented on Feb 2, 2017

   

   brson

   on Feb 2, 2017

   Contributor

   More actions

   I suggest we change it to &mut and run it through crater to see the impact. We can change it or immediately deprecate it. We can make a point release or wait until 1.16.
4. bors

   added a commit that references this issue on Feb 3, 2017

   Auto merge of #39466 - alexcrichton:fix, r=Manishearth

   ...

   This issue will close once commit 7f294e4 is merged into the 'main' branch.

   7f294e4
5. bors

   closed this as completedin #39466on Feb 3, 2017
6. alexcrichton

   added a commit that references this issue on Feb 3, 2017

   std: Fix IntoIter::as_mut_slice's signature

   ...

   This issue will close once commit 2a935f5 is merged into the 'incoming' branch.

   2a935f5
7. brson

   added 2 commits that reference this issue on Feb 4, 2017

   std: Fix IntoIter::as_mut_slice's signature

   ...

   This issue will close once commit 64cd41b is merged into the 'master' branch.

   64cd41b

   std: Fix IntoIter::as_mut_slice's signature

   ...

   This issue will close once commit 018fb3e is merged into the 'master' branch.

   018fb3e