[4.x] Avoid expensive file copy when using local source filesystem

[FrittenKeeZ]

No description provided.

[jasonvarga]

This feels like an existing issue but I'm having trouble finding it. Do you know if there's a related issue?

[FrittenKeeZ]

@jasonvarga yeah, it's this one #6495

[jasonvarga]

I see no mention of attributes on that issue.

[FrittenKeeZ]

@jasonvarga no, this is something we discovered while working on the new Comwell site

[jasonvarga]

I just feel like this specifically was discussed before. Maybe it was in Discord. 🤷

Do you have a good way to benchmark the before/after of this change?

[FrittenKeeZ]

@jasonvarga we're just in the end of our deadline for going live with a new project, but I'll have a look at it when I get some breathing space

[jasonvarga]

I did a naive benchmark. Put this in a template:

{{ assets container="assets" }}
    <li>{{ path }}</li>
{{ /assets }}

Filled an asset directory with a whole bunch of assets, deleted the .meta directory, cleared the cache, then looked at how long the tag took to render using the Antlers profiler.

~870ms before, ~315ms after.

Not really sure what situation you were in that this was affecting you drastically though. This only gets run when generating the .meta files. Regardless, nice improvement. Thanks and sorry for the delay.