feat: improve eth_getBlockReceipts perf - #7498
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 8 minutes Limit details: You’ve used all 5 included reviews currently available under your plan. You completed 29 included PR reviews in the past 7 days; at that activity level, included reviews refill at 5 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: 1 review is currently available. Based on recent review activity, included reviews refill at 5 per hour. WalkthroughEthereum receipt construction now accepts pre-collected logs. A shared helper collects logs for executed tipset messages. Block receipts collect logs once and distribute them by transaction index. Tests cover event indexing, emitter association, and revert status. ChangesEthereum receipt log handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR changes the receipt-collection implementation to improve performance, with no actionable merge-blocking risk identified at the current head. Sequence Diagram(s)sequenceDiagram
participant RPC
participant LogCollector
participant ReceiptBuilder
participant StateManager
RPC->>StateManager: load tipset messages and receipts
StateManager->>LogCollector: provide executed messages and events
LogCollector->>ReceiptBuilder: provide logs grouped by transaction
ReceiptBuilder->>RPC: return Ethereum transaction receipts
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
5c5a855 to
6af045a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
@LesnyRumcajs Also if possible can we also include some tests to make sure the indexing of transaction is correct in I mean it is correct we already know that but just adding a test if possible might make it regression free. |
Yeah, it's a good invariant to lock. |
e40e145 to
34ee1bf
Compare
34ee1bf to
1db1535
Compare
Summary of changes
Changes introduced in this pull request:
so on average almost 2x improvement, bad case 4x (and in case of bigger blocks it only gets better).
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit