Skip to content

fix: proofset conversion bug - #7499

Merged
LesnyRumcajs merged 1 commit into
mainfrom
proofset-bugfix
Aug 18, 2026
Merged

fix: proofset conversion bug#7499
LesnyRumcajs merged 1 commit into
mainfrom
proofset-bugfix

Conversation

@LesnyRumcajs

@LesnyRumcajs LesnyRumcajs commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • while deduplicating shims, I noticed a bug in proofset conversion. This addresses it. This likely never surfaced because it all goes through default policies anyway, but better safe than sorry. No changelog entry needed.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed policy conversions so enabled proof identifiers are preserved consistently across versions.
    • Added regression coverage for recent policy conversion scenarios.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a7d466e0-818c-4db8-b909-8239aa28bc55

📥 Commits

Reviewing files that changed from the base of the PR and between bd05ad9 and 716acb7.

📒 Files selected for processing (1)
  • src/shim/actors/convert.rs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • filecoin-project/lotus (manual)

Included review availability: 3 reviews are currently available. Based on recent review activity, included reviews refill at 5 per hour.


Walkthrough

The change adds a reusable proof-set conversion macro, applies it to policy conversions from v11 through v18, and adds regression coverage for enabled and disabled proof IDs.

Changes

Proof-set conversion

Layer / File(s) Summary
Shared proof-set conversion
src/shim/actors/convert.rs
Adds convert_proof_set!, which maps enabled proof flags to their indexed proof IDs.
Policy conversion wiring and regression coverage
src/shim/actors/convert.rs
Updates v11–v18 policy conversions to use indexed proof-set conversion. Tests verify that enabled IDs remain present and disabled IDs 0 and 1 are excluded.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Merge Risk: ⚪ Minimal · up to 716ac

This PR makes a localized proofset conversion fix with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: akaladarshi, eclesiomelojunior, sudo-shashank

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: fixing a proofset conversion bug.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch proofset-bugfix
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch proofset-bugfix

Comment @coderabbitai help to get the list of available commands.

@LesnyRumcajs
LesnyRumcajs marked this pull request as ready for review August 17, 2026 22:43
@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code owner August 17, 2026 22:43
@LesnyRumcajs
LesnyRumcajs requested review from EclesioMeloJunior and sudo-shashank and removed request for a team August 17, 2026 22:43
@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Aug 17, 2026
@LesnyRumcajs
LesnyRumcajs enabled auto-merge August 17, 2026 22:43
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.69%. Comparing base (bd05ad9) to head (716acb7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/shim/actors/convert.rs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd05ad9...716acb7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit 1e9b885 Aug 18, 2026
39 of 88 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the proofset-bugfix branch August 18, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants