Update libsodium to 1.0.9 - #1
Closed
woobs wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Wrong repo |
4 tasks
Closed
Closed
3 tasks
5 tasks
4 tasks
6 tasks
bevanjkay
pushed a commit
to ascarter/homebrew-core
that referenced
this pull request
Jun 10, 2026
Two related regressions in 1.0.0 prevent `container system start` from completing: 1. The previous formula patched Sources/ContainerPlugin/InstallRoot.swift via `inreplace` to hard-code the keg prefix as the install root. Upstream PR apple/container#1558 (May 2026) renamed the symbols the inreplace targeted (`CommandLine.executablePathUrl` ->`executablePath`, `deletingLastPathComponent` -> `removingLastComponent`), so the substitution silently became a no-op when 1.0.0 was bumped. The apiserver now resolves its install root as the lexical grandparent of the running executable without symlink resolution, which on /opt/homebrew/bin/container lands at /opt/homebrew rather than the keg, where no `libexec/container-plugins` directory exists. The apiserver crash-loops with "cannot find any plugins with type network" and `container system start` hangs at "Testing access to container-apiserver...". Fix this without patching upstream sources by installing the binaries to libexec/ and using `bin.env_script_all_files` to generate shim wrappers in bin/ that `exec` the real binaries via their absolute keg path. The kernel-reported executable path now has `opt_prefix` as its lexical grandparent, putting the plugin search exactly on top of `opt_prefix/libexec/container-plugins/`. The wrappers also export `CONTAINER_INSTALL_ROOT=opt_prefix` for the code paths that honor the environment variable. 2. The 1.0.0 release added a new `machine-apiserver` plugin (apple/container#1662, "container machine") under Sources/Plugins/MachineAPIServer that the formula never picks up. `container system start` fails at the "Verifying machine API server is running" step without it, so it must ship together with fix Homebrew#1 for the start command to succeed at all. Refactor the plugin installation loop to a data-driven structure so adding the new plugin (with its config.toml plus init and create-user.sh resources from Sources/Plugins/MachineAPIServer/Resources/) is a one-line addition. Codesigning mirrors what the upstream Makefile does for that binary (--prefix only, no entitlements; no `signing/machine-apiserver.entitlements` exists upstream). Verified locally with: brew install --build-from-source container brew test container brew audit --strict container container system start container list container machine list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.