Storybook: Add Story for BlockPopover - #68681
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Looks like CI is not happy. Could you fix that first? @dhruvikpatel18 |
im3dabasia
left a comment
There was a problem hiding this comment.
Thanks @dhruvikpatel18 !
Good work to start with. Left a few feedbacks.
Two things worth calling out as good — the __unstablePopoverSlot / __unstableContentRef props are correctly left out, since the public wrapper strips them.
The extra BlockList and provider are fine here, they're the minimum needed for BlockPopover to have a block element to anchor to, without which it returns null (index.js:106-108).
What?
This PR will add story for
BlockPopoverin the Storybook.Why?
Part of: #67165
Part of: #22891
Testing Instructions
BlockPopoverstory.Screenshots or screencast
BlockPopover.Screencast.mov