Skip to content

Storybook: Add Story for BlockPopover - #68681

Merged
im3dabasia merged 5 commits into
WordPress:trunkfrom
dhruvikpatel18:add/block-popover-story
Aug 14, 2026
Merged

Storybook: Add Story for BlockPopover#68681
im3dabasia merged 5 commits into
WordPress:trunkfrom
dhruvikpatel18:add/block-popover-story

Conversation

@dhruvikpatel18

@dhruvikpatel18 dhruvikpatel18 commented Jan 15, 2025

Copy link
Copy Markdown
Member

What?

This PR will add story for BlockPopover in the Storybook.

Why?

Part of: #67165
Part of: #22891

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on localhost
  3. Check the BlockPopover story.

Screenshots or screencast

BlockPopover.Screencast.mov

@shail-mehta shail-mehta added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Jan 15, 2025
@dhruvikpatel18
dhruvikpatel18 marked this pull request as ready for review January 15, 2025 12:04
@github-actions

github-actions Bot commented Jan 15, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the [Package] Block editor /packages/block-editor label Aug 11, 2026
@im3dabasia

Copy link
Copy Markdown
Contributor

Looks like CI is not happy. Could you fix that first? @dhruvikpatel18

@im3dabasia im3dabasia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhruvikpatel18 !

Good work to start with. Left a few feedbacks.


Two things worth calling out as good — the __unstablePopoverSlot / __unstableContentRef props are correctly left out, since the public wrapper strips them.

The extra BlockList and provider are fine here, they're the minimum needed for BlockPopover to have a block element to anchor to, without which it returns null (index.js:106-108).

Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated
Comment thread packages/block-editor/src/components/block-popover/stories/index.story.jsx Outdated

@im3dabasia im3dabasia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@im3dabasia
im3dabasia merged commit f3ec0c6 into WordPress:trunk Aug 14, 2026
42 checks passed
@github-actions github-actions Bot added this to the Gutenberg 23.9 milestone Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block editor /packages/block-editor Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants