Editor: Correctly mark ToolsMoreMenuGroup as a private SlotFill - #81503
Conversation
|
Size Change: +1 B (0%) Total Size: 7.71 MB 📦 View Changed
|
|
Do we know if there are actual users of this in the wild? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hard to say, directory search returns nothing. I fixed a similar leak two years ago, and no reports for it - #67271. |
|
Directory not returning anything is a good sign. |
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
What?
PR updates
ToolsMoreMenuGroupslot-fill and correctly mark them as private, preventing them from leaking to consumers using string names. This matchesViewMoreMenuGroup.Testing Instructions
None. There are no behavioral changes to consumers