Skip to content

Editor: Correctly mark ToolsMoreMenuGroup as a private SlotFill - #81503

Merged
Mamaduka merged 1 commit into
trunkfrom
fix/tools-more-menu-group-slotfill-private
Aug 12, 2026
Merged

Editor: Correctly mark ToolsMoreMenuGroup as a private SlotFill#81503
Mamaduka merged 1 commit into
trunkfrom
fix/tools-more-menu-group-slotfill-private

Conversation

@Mamaduka

Copy link
Copy Markdown
Member

What?

PR updates ToolsMoreMenuGroup slot-fill and correctly mark them as private, preventing them from leaking to consumers using string names. This matches ViewMoreMenuGroup.

Testing Instructions

None. There are no behavioral changes to consumers

@Mamaduka Mamaduka self-assigned this Aug 12, 2026
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Aug 12, 2026
@Mamaduka
Mamaduka requested a review from youknowriad August 12, 2026 12:20
@github-actions

Copy link
Copy Markdown

Size Change: +1 B (0%)

Total Size: 7.71 MB

📦 View Changed
Filename Size Change
build/scripts/editor/index.min.js 530 kB +1 B (0%)

compressed-size-action

@youknowriad

Copy link
Copy Markdown
Contributor

Do we know if there are actual users of this in the wild?

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka

Copy link
Copy Markdown
Member Author

Do we know if there are actual users of this in the wild?

Hard to say, directory search returns nothing.

I fixed a similar leak two years ago, and no reports for it - #67271.

@youknowriad

Copy link
Copy Markdown
Contributor

Directory not returning anything is a good sign.

@Mamaduka
Mamaduka merged commit dd73b57 into trunk Aug 12, 2026
53 of 54 checks passed
@Mamaduka
Mamaduka deleted the fix/tools-more-menu-group-slotfill-private branch August 12, 2026 14:04
@github-actions github-actions Bot added this to the Gutenberg 23.9 milestone Aug 12, 2026
shail-mehta pushed a commit that referenced this pull request Aug 12, 2026
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants