Skip to content

Styles Route: Reference the api-fetch and html-entities projects - #81989

Merged
youknowriad merged 1 commit into
trunkfrom
claude/styles-route-tsconfig-refs
Aug 24, 2026
Merged

Styles Route: Reference the api-fetch and html-entities projects#81989
youknowriad merged 1 commit into
trunkfrom
claude/styles-route-tsconfig-refs

Conversation

@youknowriad

Copy link
Copy Markdown
Contributor

What?

Adds the two project references missing from routes/styles/tsconfig.json: api-fetch and html-entities.

Why?

The route declares both packages as dependencies, and since #81847 brought the route projects under the typecheck run, npm run lint:tsconfig requires every dependency to be matched by a reference. The styles route's config is missing these two, so the Static Analysis job currently fails on every branch, and the pre-commit hook blocks any commit that stages a tsconfig file.

How?

Two lines, in the alphabetical positions the validator expects.

Testing Instructions

npm run lint:tsconfig

Exits 1 on trunk naming these two references; exits 0 with this change.

Use of AI Tools

Authored with Claude Code (Claude Fable 5), including this description; reviewed by the PR author.

Verified: npm run lint:tsconfig exits 0 and npx tsc -p routes/styles/tsconfig.json reports no errors on this branch.

The route declares both as dependencies, and now that route projects are
under the typecheck run their TypeScript config has to reference them.
Validation fails for every branch until it does.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad
youknowriad merged commit c96732f into trunk Aug 24, 2026
43 checks passed
@youknowriad
youknowriad deleted the claude/styles-route-tsconfig-refs branch August 24, 2026 13:59
@github-actions github-actions Bot added this to the Gutenberg 23.9 milestone Aug 24, 2026
@github-actions

Copy link
Copy Markdown

Flaky tests detected in f95c4ab.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/32735289788
📝 Reported tests:

Should save the changes in /test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js, passed after 2 failed attempts.
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js:34:14
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('role=button[name="Visual"i]')

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.js:33:55

@jeryj jeryj added the [Type] Build Tooling Issues or PRs related to build tooling label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants