Quick Draft widget: drop a reference to a class that does not exist - #82064
Merged
Conversation
styles.column was never defined; Stack direction already handles it
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.91 MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to reviewing #82053.
widgets/quick-draft/render.tsxpicks between two CSS module classes for its root layout, but only one of them exists.Why?
.columnis not defined inwidgets/quick-draft/style.module.css, and never was. In the stacked layout the ternary therefore resolves toundefinedandclsxdrops it, so the class list is the same either way.Nothing renders differently: the axis is already set by
direction={ listBeside ? 'row' : 'column' }on the sameStack, and.rowexists only to feed the descendant selector.row .primary-pane, which adds the vertical rule in the side-by-side layout.What the ternary does do is imply a
.columnmodifier that is not there, sending the next reader to look for styles that do not exist.It is also a small illustration of a gap worth naming: CSS modules are typed as
{ [ key: string ]: string }intypings/style-imports/index.d.ts, so a reference to a missing class type checks fine and reaches runtime asclassName={ undefined }. This one survived three refactors of the file without any tool noticing.How?
Replaces the ternary with a conditional, so the class is added when it applies and nothing is added when it does not.
Testing Instructions
The change is a no-op visually; the point is to confirm that.
Testing Instructions for Keyboard
No interaction changes.
Screenshots or screencast
No visual changes.
Use of AI Tools
Claude Code was used to review #82053, where this dead reference surfaced, and to draft the change. Reviewed and verified before opening.