Specifying x86 (32-bit) pypy-nightly on Windows installs a 64-bit binary

[alex]

Description:

      - name: Setup python
        uses: actions/setup-python@v4.2.0
        with:
          python-version: "pypy-3.8-nightly"
          architecture: "x86"

Action version:

4.2.0

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:

pypy-3.8-nightly, pypy-3.9-nightly

Repro steps:

Use the action specified above. Look at the output and see:

Downloading PyPy from "https://buildbot.pypy.org/nightly/py3.8/pypy-c-jit-latest-win64.zip" ...

Expected behavior:

A 32-bit binary is installed.

Actual behavior:
A 64-bit binary!

[nulano]

Expected behavior:
A 32-bit binary is installed.

There is no 32-bit Windows build of recent PyPy versions since PyPy 7.3.4.

Actual behavior:
A 64-bit binary!

Whether this action should fail or silently switch to 64-bit is a separate question, related to #168 (comment) and #201.

[alex]

Hmm, indeed. I think this should be an error then, its very confusing to request one thing and get another -- in my case it produces confusing linker errors later on.

[vsafonkin]

Hi @alex, we will take a look at this, thank you for your report.

[vsafonkin]

Hi @alex, i've merged this PR to fix it. It's available via setup-python@main at the moment and will be available via version tag after a new release of setup-python action.

[alex]

great, thanks!

[vsafonkin]

I'm going to close this issue, feel free to contact us if you have any concerns, thank you!

[graingert]

Hi @alex, i've merged this PR to fix it. It's available via setup-python@main at the moment and will be available via version tag after a new release of setup-python action.

It looks like this wasn't fixed, specifying architecture: x86 still installs the x64 version rather than raising an error