Move to TOML configuration for plugin configurations - #1422
Merged
Conversation
noah-thor
force-pushed
the
toml-plugin-config
branch
from
April 15, 2026 20:17
5089f59 to
2ebf148
Compare
katiewasnothere
self-requested a review
April 15, 2026 21:11
noah-thor
force-pushed
the
toml-plugin-config
branch
from
April 15, 2026 22:42
2ebf148 to
7163991
Compare
| return url | ||
| } | ||
| } | ||
| return nil |
Contributor
There was a problem hiding this comment.
Maybe throw notFound instead?
Contributor
Author
There was a problem hiding this comment.
It more or less conforms to the previous contract, in which create returns Plugin?. If we want to use ContainerizationError.notFound we will have to add Containerization as a dependency of ContainerPlugin.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
We'd only need to import ContainerizationError as a dependency, which is already used elsewhere in the same package
noah-thor
force-pushed
the
toml-plugin-config
branch
2 times, most recently
from
April 16, 2026 17:21
c16916d to
7838f9d
Compare
This change migrates plugin config format away from using JSON to use TOML. - Addresses the plugin portion of discussion apple#1336
noah-thor
force-pushed
the
toml-plugin-config
branch
from
April 16, 2026 19:37
7838f9d to
cf3d2b2
Compare
katiewasnothere
approved these changes
Apr 17, 2026
katiewasnothere
left a comment
katiewasnothere
left a comment
Contributor
There was a problem hiding this comment.
Small request but otherwise LGTM
jianliang00
pushed a commit
to jianliang00/container
that referenced
this pull request
Aug 28, 2026
This change migrates plugin config format away from using JSON to use TOML. - Addresses the plugin portion of discussion apple#1336 ## Type of Change - [ ] Bug fix - [X] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context Context within apple#1336 > We're looking to improve the user experience and overall functionality of setting defaults for container to better enable future use cases. > > Today container uses macOS's [UserDefaults](https://developer.apple.com/documentation/foundation/userdefaults) to configure settings needed at runtime. As mentioned in apple#608, UserDefaults may be idiomatic for macOS, but they apply globally to all sessions and do not handle representing complex, hierarchical data well. Additionally, we currently have two ways of setting these defaults, either directly with macOS's defaults command or through container system property. > > apple#608 proposes moving to use environment variables in place of UserDefaults. However, we do not believe this is sufficient. Environment variables are not in a consistent location, are not sourced from data, and also do not handle representing complex, hierarchical data well. As part of this migration to TOML for user settings we want to also move plugin settings to use TOML so that we can have a singular file format for `container` configurations. ## Testing - [X] Tested locally - [X] Added/updated tests - [ ] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change migrates plugin config format away from using JSON to use TOML.
Type of Change
Motivation and Context
Context within #1336
As part of this migration to TOML for user settings we want to also move plugin settings to use TOML so that we can have a singular file format for
containerconfigurations.Testing