Fix: memory leak and silent read error in Archiver._compressFile causing build failures under /Users/ - #1432
Merged
Conversation
…ing build failures under /Users/
Ronitsabhaya75
marked this pull request as ready for review
April 20, 2026 02:51
3 tasks
jglogan
approved these changes
Apr 22, 2026
jglogan
left a comment
jglogan
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @Ronitsabhaya75, good catch!
jianliang00
pushed a commit
to jianliang00/container
that referenced
this pull request
Aug 28, 2026
…ing build failures under /Users/ (apple#1432) - Closes apple#1439. - May also address some cases of apple#1423. - `_compressFile()` allocated a 1 MiB read buffer per file but never freed it. - It also treated InputStream.read() errors (-1) the same as EOF (0), silently swallowing errors such as TCC access denials under /Users/, which could result in unexpected archive contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_compressFilefunc leaks memory, leaks fd on error, and ignores errors. #1439.Type of Change
Motivation and Context
fixes : #1423
_compressFile() allocated a 1 MiB read buffer per file but never freed it, leaking ~20 GiB with large contexts (~20k files). It also treated InputStream.read() errors (-1) the same as EOF (0), silently swallowing TCC access denials under /Users/ and corrupting the archive state — which surfaced as the unhelpful "unable to write data to the archive, code 0" error.
Testing