ensure-container-stopped.sh: don't fail on launchctl errors - #1461
Merged
jglogan merged 1 commit intoApr 30, 2026
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Contributor
Author
|
@jglogan I've validated this against our formula in Homebrew/core and confirm |
jglogan
approved these changes
Apr 30, 2026
Contributor
|
Thanks, Patrick! Merged. |
noah-thor
pushed a commit
to noah-thor/container
that referenced
this pull request
May 6, 2026
- Fixes apple#1281. Supersedes apple#1306. - When `-a` runs as a regular user (such as via `brew install container`), two launchctl failures bubble up as a non-zero exit and break Homebrew's post-install: - `bootout` against `system` requires root. - `launchctl print` lists Mach endpoint names that aren't loaded jobs, so `bootout` returns `No such process` on them. - Skip `system` when not root, and treat individual `bootout` failures as non-fatal. Same fix applied to the non-`-a` `xargs` pipeline. Signed-off-by: Patrick Linnane <patrick@linnane.io>
jianliang00
pushed a commit
to jianliang00/container
that referenced
this pull request
Aug 28, 2026
- Fixes apple#1281. Supersedes apple#1306. - When `-a` runs as a regular user (such as via `brew install container`), two launchctl failures bubble up as a non-zero exit and break Homebrew's post-install: - `bootout` against `system` requires root. - `launchctl print` lists Mach endpoint names that aren't loaded jobs, so `bootout` returns `No such process` on them. - Skip `system` when not root, and treat individual `bootout` failures as non-fatal. Same fix applied to the non-`-a` `xargs` pipeline. Signed-off-by: Patrick Linnane <patrick@linnane.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #1281. Supersedes #1306.
When
-aruns as a regular user (such as viabrew install container), two launchctl failures bubble up as a non-zero exit and break Homebrew's post-install:bootoutagainstsystemrequires root.launchctl printlists Mach endpoint names that aren't loaded jobs, sobootoutreturnsNo such processon them.Skip
systemwhen not root, and treat individualbootoutfailures as non-fatal. Same fix applied to the non--axargspipeline.Testing