Migrate some container tests, remove concurrent demo tests. - #1840
Merged
Conversation
- Part of apple#1833. - Tweaks `ContainerFixture.withContainer()` to support the legacy `longRun()` pattern without boilerplate.
| try run(args).check() | ||
| } | ||
|
|
||
| /// Deletes a container, silencing errors if it does not exist. |
Contributor
There was a problem hiding this comment.
Should we explicitly check the error here instead of using try??
Contributor
Author
There was a problem hiding this comment.
I added an ignoreFailure parameter defaulting to false.
katiewasnothere
approved these changes
Jun 26, 2026
Code Coverage
|
katiewasnothere
approved these changes
Jun 26, 2026
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jul 16, 2026
- Part of apple#1833. - Tweaks `ContainerFixture.withContainer()` to support the legacy `longRun()` pattern without boilerplate.
jianliang00
pushed a commit
to jianliang00/container
that referenced
this pull request
Aug 28, 2026
- Part of apple#1833. - Tweaks `ContainerFixture.withContainer()` to support the legacy `longRun()` pattern without boilerplate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContainerFixture.withContainer()to support the legacylongRun()pattern without boilerplate.Type of Change
Motivation and Context
See above.
Testing