Add readiness signal to DirectoryWatcher, fix DirectoryWatcherTest. - #2066
Merged
Conversation
- Fixes apple#2065. - `startWatching()` returns before the watcher is ready to receive events, resulting in dropped events. Add readyEvents, an AsyncStream that yields once the watcher is actually active, so callers can await real readiness instead of guessing a sleep duration. - Prevent concurrent callers to startWatching(), as it does not support this mode of operation. - This fixes DirectoryWatcherTest's intermittent flakes.
jglogan
changed the title
JaewonHur
approved these changes
Aug 4, 2026
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/etc/resolversdirectory watcher has racy startup, results in test flakes. #2065.startWatching()returns before the watcher is ready to receive events, resulting in dropped events. Add readyEvents, an AsyncStream that yields once the watcher is actually active, so callers can await real readiness instead of guessing a sleep duration.Type of Change
Motivation and Context
Principally to address test flakes, but it does address startup races.
Testing