Extracts createPluginLoader() for use by container k8s. - #2115
Merged
Conversation
jglogan
force-pushed
the
extract-makepluginloader
branch
from
August 12, 2026 23:00
a33d707 to
3c3bff9
Compare
jshi991
approved these changes
Aug 12, 2026
Code Coverage
|
egernst
approved these changes
Aug 13, 2026
This was referenced Aug 28, 2026
henrywang
added a commit
to henrywang/Berthly
that referenced
this pull request
Sep 3, 2026
…#137) Closes #131. Closes #132. ## #131 — k8s parity re-check apple/container#2115 (`createPluginLoader` extracted to a shared `Utility` helper) and #2110 (`K8sHelper` split, `NodeProvisioner` protocol) reorganized the k8s code in 1.3.0. The structural blocker `PARITY.md` documents is unchanged: `loadKindnetManifest` (now in `K8sHelper+Bootstrap.swift`) still resolves its CNI manifest via `pluginLoader.findPlugin(forExecutable: CommandLine.executablePath)`, which a non-plugin binary can't satisfy; the post-`create` workflow is still `kubectl`; and `container k8s` is still marked `EXPERIMENTAL`. Rationale updated to record the recheck. ## #132 — mock kernel fixtures Bumped the stale kernel strings in mock/preview fixtures to 1.3.0's live defaults (read from a running 1.3.0 daemon): - `vmlinux-6.18.15-186` → `vmlinux-6.18.35-197-debug` - Kata `3.28.0` release URL → `3.32.0` - machine kernel display `6.12.4-arm64` → `6.18.35-arm64` Display-only; the one affected unit test (`kernelNameIsBinaryFilename`) updates its input and expectation together. ## Test plan - [x] `swiftlint lint --strict` — 0 violations - [x] `BerthlyTests` — all pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createPluginLoader()for use bycontainer k8s. #2114.Application.createPluginLoader()inContainerCommandstoUtilityinContainerAPIClientso we don't have to define a redundant copy of the function inContainerK8s.